-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Styles Breakdown #20331
Comments
Sharing some thoughts on the current status for infrastructure/ my interpretation of some infrastructure tasks:
It seems the style attribute we are using for colors introduced in #21021 addressed this part we are also using it for lineHeight with success and without the need to register new attributes.
It seems this is about making sure styles are regenerated when the structure that holds global style changes. For example, #20530 accomplishes this by compiling the styles on GlobalStylesProvider.
We can achieve this by adding a styles structure to theme.json:
We may also achieve the "Custom User Styles" part of #7551 by just allowing the user to save the current block style attributes as a customization of the theme.json structure. |
At this week's Block-based Themes meeting, the group discussed some of the upcoming design tools in this ticket, and whether they should be opt-in or opt-out for themes. Here are our notes:
More details in the meeting notes. |
With the first beta version of WordPress 5.7 not very far away I'm sharing this summary after some discussion with @nosolosw specifying what are the tasks we think should be part of v1 and/or that may be part of v1. What we will do next?These are the tasks we will work on and plan to have ready soon. Are the most prioritary tasks.
What we can do next?Tasks we can work on, it would be nice to have but are not a must and are lower priority may or may not be part of v1.
Things for the futureNot part of a first version. Things we may consider in the future.
Related tasks but that initially will not use theme.json/global styles mechanisms.
What decisions do we need to do?
What’s next on the UI/UX side?The first beta of WordPress 5.7 goes out in January, so we need to have a v1 for the UI ready sometime before the first beta.
cc: @nosolosw, @shaunandrews, @jasmussen, @ItsJonQ, @mcsf, @youknowriad |
This week's status report: Shipped
Ongoing
|
This week in global styles: Landed theme.json with elements #29891
Block Supports & theme.json properties:
Bugfixes, code quality
Ongoing theme.json with elements #29891
Block Supports:
Bugfixes:
Priorities The priority continues to be shipping #29891 as soon as possible to unblock related work. #28913 is a good issue to look at if you can lend a hand (help with reviews, migrate more blocks, more properties, etc). |
Weekly status report for core-editor meeting. Shipped this week theme.json block.json / block supports
Internationalization
KSES
Site editor:
Ongoing theme.json
block.json / block supports
New style properties
Misc
Priorities The priority continues to be shipping #29891 as soon as possible to unblock related work. #28913 is a good issue to look at if you can lend a hand (help with reviews, migrate more blocks, more properties, etc). |
Status report for core-editor meeting. Shipped this week: block.json / block supports:
theme.json
Extensibility:
Site editor:
Ongoing: block.json / block supports:
theme.json
Priorities After having landed #29891 via #30541 the priority is to tie up the loose ends before preparing the core patch for 5.8. Worth highlighting is that there're two new issues to switching away from CSS Custom Properties for link #31488 and font-family #31489 (see rationale in each issue). |
Status Report (core-editor meeting). Global Styles and Global Settings have been ported to WordPress core and will be part of the WordPress 5.8 release. The focus now is on polishing and fixing bugs as we find them. The issue description & tasks have been triaged and there're two new sections: "bugfixes" and "docs" with tasks to be worked on in the upcoming weeks. Now that the 1.0 version of this feature has been shipped and we need to revisit focuses, I thought it'd be a good time to pause these reports while we figure out the next steps. Anything relevant should still be posted here but on an on-demand basis not weekly. Supported settings & styles that landed core There's a task above to update this in the docs but wanted to share what we have now.
Shipped this week Port to core:
Block Supports:
theme.json
Misc:
|
We're shipping a first version of the GS interface in 5.9, so it looks like this issue could be closed. Both for having a sense of progress but also because the activity has already moved to other smaller and more focused issues (designer tools, site editor improvements, framework changes, etc). |
I've created #37550 to track some gaps we still have from the original vision of styles at the framework level. |
Really wonderful work and progress here! |
This is an overview of the concrete tasks needed to proceed with the project scope of #9534 (see also #19611). It operates on three levels, or style origins: local blocks, theme defaults, and global modifications.
First 🌊
Goal: prototype a system that connects the three style origins and demonstrates how it works for a few top-level blocks.
Infrastructure
Ensure at all times the editor reflects the front faithfully.
font-size
,color
) and introduce missing properties (line-height
,family
). Consolidate the style attributes of blocks #22700theme.json
specification for controlling the editor and the style attributes of different origins. Document experimental theme.json #22518 Block editor: Controlling the Block Editor #20588Interface
These are the different tools that interact with appearance values.
edit-site
. This should be a straightforward rendering of a sidebar in the site editor displaying the global values and palette. Add global styles sidebar at edit site screen #24250Second 🌊
Goal: develop all necessary sub-systems.
Infrastructure
Prepare a core patch for 5.7 (closed)Global Styles in WordPress 5.7 #27506Control design tools visibility (superseded)Controlling design tools visibility #27295global
selector intodefaults
androot
Update theme.json: split global block selector into root and defaults #28533/24165.
global
. Automatically generate required preset classes #25768Interface
Third 🌊
Goal: merge the non UI parts of global styles in WordPress 5.8.
block.json / block supports:
border-width
,border-style
,border-color
theme.json:
wp_theme
taxonomy instead of post_name to associate user styles with particular themes.Internationalization:
Docs:
theme.json
docs for WordPress 5.8 #33131theme.json
. Theexperimental-link-color
theme support will be deprecated and removed when the plugin requires WordPress 5.8 as the minimum version. Update documentation for link color in WordPress 5.8 #33162__experimentalSkipSerialization
.Extensibility:
Bug fixes
settings.color
no longer have the theme colors Theme's color palette no longer returned via Block Editor settings #32027 Enqueue core and theme colors by using separate structures per origin. #32358Fourth 🌊
Follow-ups to WordPress 5.8 release.
Block supports:
theme.json:
text
andbackground
color viatheme.json
#34414theme.json
#34317layout.wideWidth
value #34507Stylesheet:
Performance:
theme.json
to style individual blocks #33977Interface
Backlog
The things listed here don't need to be necessarily implemented, but should be considered.
block.json: nothing planned
theme.json
core/group core/paragraph
. Updates to experimental-theme.json #28163font
,color
, pagebackground
) can be conceptualized as attributes of a root Site block. [Explore] Site Block #16998 Related: consider global site width and padding Explore adding site width and padding to global styles #20771Expand to more style properties:
height
Separator: Add means to control height #28409margin
Custom Margin/Padding to column block #25988width
Add width to setting and styles #31037wp_register_font_family
.Extensibility:
theme.json
configs (including user preferences) as part of exporting templates & template parts Exporting Block Themes and Styles #27941 Site Editor: Export global style settings #27528Interface:
__experimentalSelector
of the heading block). How is this in the new UI?Iterate on design tools:
Misc:
prefers-color-scheme
media-query #24368The text was updated successfully, but these errors were encountered: