Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow for editing the styles of a specific block type #27393

Closed
mtias opened this issue Dec 1, 2020 · 4 comments
Closed

Flow for editing the styles of a specific block type #27393

mtias opened this issue Dec 1, 2020 · 4 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented Dec 1, 2020

In the global styles context, it should be possible to go from block to editing that block's global styles properties. Maybe a first start could be adding an action to the ellipsis menu "Edit Global Styles":

image

@mtias mtias added Needs Design Feedback Needs general design feedback. [Feature] Full Site Editing Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Dec 1, 2020
@jorgefilipecosta
Copy link
Member

An additional possibility discussed in a conversation with @mtias was a design tool/ block global styles select tool

The tool can be a top-level button on the toolbar, when we press the button we activate a block select mode. When we click on a block we automatically open the global styles panel for that block.

This tool is implemented in addition to the system referred to on this issue.

@mtias mtias added Needs Design Needs design efforts. and removed Needs Design Feedback Needs general design feedback. labels May 23, 2022
@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
@jasmussen
Copy link
Contributor

This seems related to "push styles to global", and it would be good to consolidate. A use case, I'm writing a post on my brand new blog and using a Quote block for the first time, and realizing it looks poor. I might want to style it locally there, then push it to global. While this is possible with "push to global", it can be refined with a modal before/after preview. It can perhaps take inspiration from how you update components in Figma.

@jameskoster
Copy link
Contributor

Since it's possible to apply a block styles globally now we might consider this issue complete.

But that flow could use some improvements. For example:

  • Displaying a before/after preview & diff, either in a modal or the multi-entity save panel.
  • The shortcut suggested in the OP could open the global styles panel with the style book focussed on the selected block
  • Consider granularity of pushable changes in the local context. Currently you can only push all local changes, there might be an argument for a more selective experience.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 8, 2023
@annezazu
Copy link
Contributor

Closing this out considering the above discussion and the fact that "Apply globally" is an option under advanced. For improving this, let's open up individual issues going forward like so #57740 and potentially consolidate with an iteration issue if we want to see something ship in a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants