Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The inspector in the widgets customizer should follow accessibility best practices #30271

Closed
kevin940726 opened this issue Mar 26, 2021 · 0 comments · Fixed by #30431
Closed

The inspector in the widgets customizer should follow accessibility best practices #30271

kevin940726 opened this issue Mar 26, 2021 · 0 comments · Fixed by #30431
Assignees
@kevin940726
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@kevin940726
Copy link
Member

  • Pressing esc should close the inspector.
  • Scrolling in the inspector should trigger the header to be sticky.
  • Opening the inspector should move focus to its first focusable element (the back button)

Originally posted by @kevin940726 in #29755 (comment)
@kevin940726 kevin940726 added [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Mar 26, 2021
@kevin940726 kevin940726 self-assigned this Mar 26, 2021
This was referenced Mar 26, 2021
Closed
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin940726 kevin940726

Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Widgets: Refactor the inspector in Widgets Customizer to use core's controls WordPress/gutenberg
1 participant
@kevin940726