-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site logo: Fix range control on landscape logos #37733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the minimum width is an integer when calculating the minimum logo size. This fixes a bug where the range controller returned numbers that wasn't an integer on landscape logos.
walbo
added
[Type] Bug
An existing feature does not function as intended
[Block] Site Logo
Affects the Site Logo Block
labels
Jan 5, 2022
Size Change: +8 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected. Thanks, @walbo.
Mamaduka
reviewed
Jan 6, 2022
@noisysocks should we backport this into RC or label it for minor release? |
The bug was spotted during the beta period and I don't see any string changes so all good to backport 👍 |
noisysocks
added
the
Backport to WP Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Jan 10, 2022
jorgefilipecosta
pushed a commit
that referenced
this pull request
Jan 10, 2022
* Site logo: Fix range control on landscape logos Make sure the minimum width is an integer when calculating the minimum logo size. This fixes a bug where the range controller returned numbers that wasn't an integer on landscape logos. * Make sure minHeight is a integer
noisysocks
removed
the
Backport to WP Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Jan 10, 2022
noisysocks
pushed a commit
that referenced
this pull request
Jan 10, 2022
* Site logo: Fix range control on landscape logos Make sure the minimum width is an integer when calculating the minimum logo size. This fixes a bug where the range controller returned numbers that wasn't an integer on landscape logos. * Make sure minHeight is a integer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Site Logo
Affects the Site Logo Block
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure the minimum width is an integer when calculating the minimum logo size. This fixes a bug where the range controller returned numbers that wasn't an integer on landscape logos.
Fixes #37716
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).