Update: Improve escaping on the search block #37829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
jorgefilipecosta
requested review from
oandregal,
gziolo,
mcsf,
youknowriad and
ellatrix
jorgefilipecosta
force-pushed
the
update/improve-escape-on-the-search-block
branch
from
d219daa
to
ac7a158
Compare
oandregal
approved these changes
Jan 10, 2022
jorgefilipecosta
deleted the
update/improve-escape-on-the-search-block
branch
jorgefilipecosta
added a commit
that referenced
this pull request
Jan 10, 2022
noisysocks
removed
the
Backport to WP Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the escaping on the search block to make it consistent with what happens on other blocks.
Testing
I verified the search block and its styles still work as expected.