Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Top Toolbar position in template part focus mode to be consistent with other editors #37946

Closed
jameskoster opened this issue Jan 13, 2022 · 5 comments
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Focus Mode Zoomed in focus mode for editing things like template parts Needs Design Feedback Needs general design feedback.

Comments

@jameskoster
Copy link
Contributor

When you enable the "Top Toolbar" option it appears like so when editing a template part in focus mode:

Screenshot 2022-01-13 at 10 54 25

This looks a little strange. It might be better to do something like:

Screenshot 2022-01-13 at 10 57 14

This would make it consistent with other editors, including the template editor which also utilises the dark frame:

Screenshot 2022-01-13 at 11 01 30

@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. [Feature] Focus Mode Zoomed in focus mode for editing things like template parts labels Jan 13, 2022
@jasmussen
Copy link
Contributor

Definitely better! Tangentially to this, a while back I explored what it might look like if the option still fixed the toolbar to the top, but still retained the same visual appearance of the floating version. The primary benefit would be an identical toolbar design that remained consistent across mobile and tablet previews as well. I ultimately feel these mockups were not succesful, but wanted to share in case they inspired better solutions.
Top Toolbar
Top Toolbar, Mobile
Top Toolbar, Template Editor

@jameskoster
Copy link
Contributor Author

At some point I think it might be beneficial to evaluate the full scope of the top bar, and consider a more intentional / scalable design. Since it was originally implemented we've added so many features, not to mention new editing contexts. It feels a little bit like a soap box car right now :D

@mtias
Copy link
Member

mtias commented May 23, 2022

Related #40450.

@jameskoster jameskoster added the [Block] Template Part Affects the Template Parts Block label Jun 24, 2022
@jordesign
Copy link
Contributor

jordesign commented Sep 14, 2023

I'm seeing the tools appearing in the very top of the editor - even in the focus mode for template parts - so I'm going to close this issue as no longer reproducible.

Screenshot 2023-09-14 at 8 54 53 pm

@jordesign jordesign closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2023
@jameskoster
Copy link
Contributor Author

Thank you @jordesign!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Focus Mode Zoomed in focus mode for editing things like template parts Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

4 participants