Template editor: Show the inserter if the template part is empty #41024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.91 kB (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
Could you include screenshots? I'm not seeing the inserter 🤔
|
|
Yes I missed a thing in the logic as I reversed it and renamed the constant before submitting the PR :) |
|
In the regular editor we use the outlined [+] button in empty template parts:
Should we align with that here, or perhaps just put a regular inserter button in the middle of the canvas?
|
priethor
added
[Type] Bug
|
Of the two inserter examples above, I prefer the first one with the outline. I am not sure yet how to change the inserter, will research :) |
|
Using the Looking at the result, I think it needs space above it. appender.mp4The video shows the template part creation from the Site Editor template part list to the template editor. Once in the template editor, the browser window width is reduced by the user. When I reduce the window width, there is an empty element with the class ".block-editor-block-contextual-toolbar.is-fixed" above the inserter that has a visible bottom border, and this does not look correct. But I confirmed that this is an issue even without the inserter enabled/without this PR. |
|
I think that second issue is related to the top toolbar: #37946 |
|
Looking at this in context I have a slight preference for the regular inserter appearance. We can probably remove the forced
What do you think? |
|
I spent another hour on this, but I was not able to create the custom appender according to the design. |
I don't think we need a custom one, just the regular one would do the trick. The positioning is probably less important. |
|
The regular one shows the paragraph block placeholder. |
|
Oh yeah 🤦♂️ Perhaps the empty paragraph approach is ok afterall, if we remove the 100% height on the empty container. What do you think? |
|
I couldn't find a way to remove the 100% height only when the template part is empty. |
carolinan
added
the
Needs Technical Feedback
|
@kevin940726 I believe you implemented the fixed height here, any chance you could take a look? |
|
@carolinan @jameskoster Just checking in here, how close are we to merging this? Even if we cannot fix the 100% height, having an empty paragraph (or alternative inserter button) is still a massive improvement over the current display and it would be really good to get this into 6.0 and we are hours away from RC3 😅. We can always iterate further in 6.0.1 or 6.1. |
aristath
approved these changes
May 17, 2022
jameskoster
approved these changes
May 17, 2022
|
Thanks @jameskoster! @gziolo @adamziel we have two approvals on this and tests are passing, so should be good to backport for RC3. |
|
I just cherry-picked this to wp/6.0 branch to be included in the next release: 1c8ab8f |
adamziel
removed
the
Backport to WP Beta/RC
I think that's actually a bug. I tried to fix it a while ago, not sure why it came back 🤔. Ideally, the height should fit the content of the frame. |
|
Maybe related to #38910 ? |
Probably not because that only affects the post editor? Maybe the bug is never fixed correctly, that's also possible 😅. |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Displays the inserter in the template editor if you are editing an empty template part, like a newly created part.
Closes #37524
Why?
When you create a new template part using the Add New button in the Site Editor template part list, the editor is empty.
This PR can be a short term fix until contextual block patterns can be shown. See #41008
How?
Updates the existing condition for showing the inserter to include a check if the template is empty or not.
Testing Instructions
It should show the same regardless of what area is select when creating the part.
Screenshots or screencast