Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post Author block throw console error when there is no postId #40909

Closed
mauriac opened this issue May 7, 2022 · 1 comment · Fixed by #40910
Closed

Post Author block throw console error when there is no postId #40909

mauriac opened this issue May 7, 2022 · 1 comment · Fixed by #40910
Assignees
@mauriac
Labels
[Block] Post Author Affects the Post Author Block [Type] Bug An existing feature does not function as intended

Comments

@mauriac
Copy link
Member

mauriac commented May 7, 2022 •
edited
Loading

Description

Changing author with Post Author block raise up console error

Step-by-step reproduction instructions

  1. Open Site Editor.
  2. Choose Home template,
  3. Add a Post Author block
  4. In the block's setting, change the author from the current to any other author.
  5. notice the error throw in the browser console

Screenshot_gutenber_post_author

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@mauriac mauriac added [Type] Bug An existing feature does not function as intended [Block] Post Author Affects the Post Author Block labels May 7, 2022
@mauriac
Copy link
Member Author

mauriac commented May 7, 2022

Seems to be introduced here: #19894 (looks like an oversight).

As per @draganescu's comment here <<I think that drop-down should not show if there is not post. >>; I'm going to ship a patch for that.

@mauriac mauriac self-assigned this May 7, 2022
@mauriac mauriac mentioned this issue May 7, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 7, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauriac mauriac

Labels
[Block] Post Author Affects the Post Author Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Post Author block: Hide select author controle if there is no postId mauriac/gutenberg
2 participants
@priethor @mauriac