-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/block-editor
getSettings()
does not return custom settings added from filter
#41338
Comments
Hi @coreyworrell, I took a look at the PR(#37854) that was the source of the post.
As for gutenberg/packages/editor/src/store/selectors.js Lines 1177 to 1186 in bdad97f
@youknowriad |
Thank you for reporting this, @coreyworrell and thank you for taking a look, @t-hamano. This issue has not seen any activity for a while. Could you please confirm if this is still reproducible? Thank you! |
Thank you for the reminder, @mrfoxtalbot. @coreyworrell |
Thank you @t-hamano! |
Description
According to https://make.wordpress.org/core/2022/05/03/block-editor-miscellaneous-dev-notes-for-wordpress-6-0/#removed-6-2,
wp.data.select( 'core/editor' ).+ name
has been deprecated in favor ofwp.data.select( 'core/block-editor' ). + name
.When using the filter
block_editor_settings_all
, additional settings aren't always included incore/block-editor
, for example when editing a page. They are included when editing widgets though.Step-by-step reproduction instructions
Then on
post.php
And those values are swapped on the widgets page.
Screenshots, screen recording, code snippet
No response
Environment info
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: