Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Locking: Tabindex lost when lock icon is removed from the block menu #42681

Open
annezazu opened this issue Jul 25, 2022 · 0 comments
Open
Labels
[Feature] Block Locking The API allowing for the ability to lock/unlock blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

This was noted as part of the fifteenth call for testing for the FSE Outreach program.

As a concrete example, removing any lock setting via keyboard nav seems to drop the user back into the global context, needing to tab to the location they were previously at. I think that’s likely due to the lock DOM element no longer being present.

cc @Mamaduka

Step-by-step reproduction instructions

  1. Lock a block.
  2. Using your keyboard, go to unlock the same block that was just locked.
  3. Notice that after locking, focus is lost on the item you are locking/unlocking.

Screenshots, screen recording, code snippet

locking.unlocking.mp4

Environment info

  • WordPress 6.0.2
  • Gutenberg 13.7

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [a11y] Keyboard & Focus [Feature] Block Locking The API allowing for the ability to lock/unlock blocks labels Jul 25, 2022
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Keyboard & Focus labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Locking The API allowing for the ability to lock/unlock blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants