Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separator Block: background color defined in theme.json is not applied correctly #43660

Closed
luminuu opened this issue Aug 26, 2022 · 4 comments · Fixed by #44943
Closed

Separator Block: background color defined in theme.json is not applied correctly #43660

luminuu opened this issue Aug 26, 2022 · 4 comments · Fixed by #44943
Assignees
Labels
[Block] Separator Affects the Separator Block [Type] Bug An existing feature does not function as intended

Comments

@luminuu
Copy link
Member

luminuu commented Aug 26, 2022

Description

When defining a different background color for the separator block through theme.json or a style variant, the color is not properly displayed.

Through theme.json, only the background-color is defined. To actually change the color, the text color or the border color also has to change. Text color is deactivated in block.json, border controls are not available at the separator block.

Changing the color through the settings in the block editor or site editor adds classes like has-vivid-red-color, which then changes the color. It uses the color CSS property instead of background-color.

Possible solutions:

  • When rendering theme.json, add a CSS property with color or border-color and the defined color
  • Enable text color as setting and remove background color
  • Update separator to use default border controls of Gutenberg

Step-by-step reproduction instructions

  1. Create a style variation of a block theme
  2. Change the color for the separator block through style-variant.json
  3. Check the website and see that the color did not change

Screenshots, screen recording, code snippet

No response

Environment info

  • WordPress 6.0.1
  • Gutenberg 13.9
  • Twenty Twenty-Three
  • Custom Style Variation

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added Needs Testing Needs further testing to be confirmed. [Block] Separator Affects the Separator Block labels Aug 28, 2022
@luminuu
Copy link
Member Author

luminuu commented Aug 31, 2022

The style variation I worked on where I discovered this issue (Figma only atm): WordPress/twentytwentythree#135

@ndiego ndiego added [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels Sep 27, 2022
@ndiego
Copy link
Member

ndiego commented Sep 27, 2022

I was able to get a color to show up by setting text color in theme.json. But clearly there are still issues here.

	"styles": {
		"blocks": {
			"core/separator": {
				"color": {
					"text": "red",
					"background": "red"
				}
			},

image

@ockham
Copy link
Contributor

ockham commented Sep 28, 2022

@c4rl0sbr4v0 @michalczaplinski and I will look into this.

@ockham
Copy link
Contributor

ockham commented Oct 17, 2022

@c4rl0sbr4v0 has filed #44943 to fix this 🙂

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Separator Affects the Separator Block [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

7 participants