Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Featured Image block: Enable gradient overlay #43676

Closed
luminuu opened this issue Aug 29, 2022 · 4 comments · Fixed by #43838
Closed

Post Featured Image block: Enable gradient overlay #43676

luminuu opened this issue Aug 29, 2022 · 4 comments · Fixed by #43838
Labels
[Block] Post Featured Image Affects the Post Featured Image Block [Type] Enhancement A suggestion for improvement.

Comments

@luminuu
Copy link
Member

luminuu commented Aug 29, 2022

What problem does this address?

While creating a design for Twenty Twenty-Three, I noticed it's not possible to add a gradient overlay to the featured images of posts, as the Post Featured Image block is used, where this feature is not available. It would be possible with using a Cover block, which can also display the featured image; however it's not intended to change the markup of Twenty Twenty-Three.

What is your proposed solution?

To enhance the Post Featured Image block, the overlay feature from the Cover block should be made available. This would enable more design possibilities using this block, without having to rely on the Cover block instead.

@luminuu
Copy link
Member Author

luminuu commented Aug 31, 2022

The style variation I was working on where I discovered this issue (Figma only atm): WordPress/twentytwentythree#134

@RahiDroid
Copy link
Contributor

Hi @luminuu 👋

Came here tracking down conversations from TT3. I think I might be able to help with this one. I have a work-in-progress PR ready with some base. I had a question though, should the overlay settings be applied to the placeholder too? Checkout the screencast in PR RahiDroid#1

@luminuu
Copy link
Member Author

luminuu commented Sep 3, 2022

Hi @luminuu 👋

Came here tracking down conversations from TT3. I think I might be able to help with this one. I have a work-in-progress PR ready with some base. I had a question though, should the overlay settings be applied to the placeholder too? Checkout the screencast in PR RahiDroid#1

Thank you @RahiDroid for your work on this! I don't know if it's possible to set a default overlay via theme.json, I haven't tested it at the Cover block so far. If this would be possible it would be very nice to have it at the Post Featured Image block, so the design is reflected even if there are no images uploaded yet to the site. Makes sense to me.

@RahiDroid
Copy link
Contributor

RahiDroid commented Sep 4, 2022

Heyya @luminuu 👋

I did some testing and research, and it doesn't seem possible to set a default overlay color using theme.json. Regardless, I applied the overlay settings on the placeholder, too.

I have raised PR #43838 for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Featured Image Affects the Post Featured Image Block [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants