Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to pin typography settings #45283

Open
ariel-maidana opened this issue Oct 25, 2022 · 17 comments
Open

Add the ability to pin typography settings #45283

ariel-maidana opened this issue Oct 25, 2022 · 17 comments
Labels
[Feature] Block settings menu The block settings screen [Feature] Typography Font and typography-related issues and PRs Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@ariel-maidana
Copy link

What problem does this address?

For some users, it is frustrating to manually open typography settings for each block (like Line Height, Letter Spacing, Decoration, etc.):
Screen Capture on 2022-10-25 at 11-59-36

What is your proposed solution?

Add an option in the Editor Settings to pin or leave certain settings open by default in the Block Settings.

@kathrynwp kathrynwp added [Type] Enhancement A suggestion for improvement. [Feature] Typography Font and typography-related issues and PRs [Feature] Block settings menu The block settings screen labels Oct 25, 2022
@Psmeg
Copy link

Psmeg commented Jul 23, 2024

This really needs to be implemented in some form—whether that is through a simple toggle switch for basic/advanced or, at the very least, saving the setting changes to a config or settings file for consistency across the editor.

@darko018
Copy link

This need to be implement as soon as possible

@festive-day
Copy link

Please implement via settings or switch

@afmarchetti
Copy link

This need to be implemented

@maltmann-muc
Copy link

I fully agree with this feature request.
Also applies to the other setting sections like dimensions.

@culturerich
Copy link

Agree with this, but it should apply to all design options (not just Typography), see #55994.

Plus state persistence across blocks in #55836.

@Marksson
Copy link

Here's my upvote for this! I totally agree.. and ideally, this kind of improvements are implemented in any place where it makes sense.

@ahmedzeidan
Copy link

I agree with @Psmeg. It would be nice to have this feature to improve the workflow within the editor.

@gravnetic
Copy link

The order and pinning of modules is a very good idea! Another approach might be to remember my last state and apply to future editor refresh/load similiar to any design app that exists.

@ohiawins
Copy link

ohiawins commented Jul 25, 2024

1UP on this issue. I feel like the setting would be best placed in the Preferences >> Blocks panel which can be accessed anywhere by clicking the vertical elipsis icon in the top menu.

Uploading pin-type.mov…

Screenshot 2024-07-25 at 11 11 24

@JakJakson
Copy link

JakJakson commented Jul 28, 2024

Yep @ariel-maidana and @Psmeg - 1 zillion percent this should be implemented ASAP - can't image how many hours over the the course of a year this would save me!

@martin8032
Copy link

+1

@mattreport
Copy link

+1 For being able to expose/save these more detailed options in the block panel. I prefer @ohiawins's approach to the issue, having a global setting in the Preferences > Block panel window is a sound approach.

@Psmeg
Copy link

Psmeg commented Jul 30, 2024

The order and pinning of modules is a very good idea! Another approach might be to remember my last state and apply to future editor refresh/load similiar to any design app that exists.

I'd love to see both implemented so that new users can set their preferences on first editing content, and anyone using a blueprint could set the preferences and have that globally assigned and available during the deployment phase of the blueprint site.

@bacoords
Copy link
Contributor

To see this gain traction, I recommend focusing on a very narrow scope and not adding additional ideas to the thread, even though we'd all agree that "persistence" of settings/panels is a broader issue.

From what I recall, the broader idea of tab persistence got held up due to accessibility concerns and some upstream changes that needed to be addressed.

Personally, I also think panel persistence also is a huge UX issue that makes it worth pursuing a solution, but these should be all a separate conversations on their respective issues so that it doesn't limit the ability for this specific feature to be merged.

The next steps here would be defining and agreeing on scope- for example:

  1. When I open a typography setting, does it stay open just for this single block, for all blocks that are the same type (all paragraphs, for example) or all blocks that have typography settings at all?
  2. Should this be available for any "tools" UI in general so that it also applies outside of typography, say to colors, background image, etc?
  3. Are we in agreement that this should be an "opt-in" feature that would require a new hidden setting in the preferences panel? Or should it be opt-out? What would that setting be called?

Then once that's done, designing a mockup of what that setting would look like in the Preferences panel.

@JakJakson
Copy link

Recon it should be "opt-out" @bacoords - else newbie users will get lost - OR- there's a toggle on each setting that clearly says "show all settings" and stays on until its toggled off?

And yeah, any panel that has user editable settings should have he option to "show all"

@PouicPouic-MCD
Copy link

It should be possible to choose to have some options open by default when loading or editing a page, not only Typography, but all options, Advanced Options etc. Or, as said above, to remember last state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block settings menu The block settings screen [Feature] Typography Font and typography-related issues and PRs Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests