Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP unit test coverage for duotone block supports #48346

Open
getdave opened this issue Feb 23, 2023 · 1 comment
Open

Add PHP unit test coverage for duotone block supports #48346

getdave opened this issue Feb 23, 2023 · 1 comment
Labels
[Feature] Colors Color management [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Feb 23, 2023

As evidenced by this PR
the PHP side of the duotone block supports is potentially brittle and prone to regressions.

We should break gutenberg_render_duotone_support into smaller units and add tests for the results to provide more confidence. This should also make the code easier to reason about.


@draganescu @scruffian Thanks for catching custom color breakage. I've reinstated some code I accidentally removed during a refactor. Points to this code being brittle and requiring tests.

Originally posted by @getdave in #48318 (comment)

@getdave getdave changed the title Adds PHP unit tests for duotone block supports Add PHP unit test coverage for duotone block supports Feb 23, 2023
@getdave
Copy link
Contributor Author

getdave commented Feb 23, 2023

Related #48347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Colors Color management [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants