Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JS component level tests to editor Duotone hooks #48347

Open
getdave opened this issue Feb 23, 2023 · 1 comment · May be fixed by #48353
Open

Add JS component level tests to editor Duotone hooks #48347

getdave opened this issue Feb 23, 2023 · 1 comment · May be fixed by #48353
Assignees
@getdave
Labels
[Feature] Colors Color management [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Feb 23, 2023

As seen in #48318 it's easy to introduce regressions into the Duotone support added to blocks.

We should follow the existing tests for other hooks and introduce component level tests for the withDuotoneControls HOC. We should assert on:

  • whether the panel renders based on block supports
  • whether the stored attribute can be converted into the correct UI representation in the panel
  • whether the panel triggers the correct changes to the attribute
  • anything else?
@getdave getdave mentioned this issue Feb 23, 2023
Open
@getdave
Copy link
Contributor Author

getdave commented Feb 23, 2023

Related #48346

@getdave getdave linked a pull request Feb 23, 2023 that will close this issue
Open
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 23, 2023
@kathrynwp kathrynwp added the [Feature] Colors Color management label Feb 23, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Feature] Colors Color management [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add component level tests to withDuotoneControls HOC WordPress/gutenberg
3 participants
@getdave @jordesign @kathrynwp