Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles: Iterate on revisions note in top toolbar #51202

Closed
annezazu opened this issue Jun 2, 2023 · 3 comments · Fixed by #58057
Closed

Styles: Iterate on revisions note in top toolbar #51202

annezazu opened this issue Jun 2, 2023 · 3 comments · Fixed by #58057
Assignees
@annezazu
Labels
[Feature] History History, undo, redo, revisions, autosave. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Copy Review Needs review of user-facing copy (language, phrasing) Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Jun 2, 2023

Currently, we list "Global styles revisions" in the title bar section when viewing revisions for Styles:

Screen Shot 2023-06-02 at 9 04 15 AM

In general, I'm under the impression that "Global Styles" is the technical project name and not something to surface or reference to users in most cases. As a result, I think we should update this to say "Style Revisions" and perhaps have it share some commonality with the new title bar #50378

Screen Shot 2023-06-02 at 9 06 28 AM

cc @WordPress/gutenberg-design
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Type] Copy Issues or PRs that need copy editing assistance Needs Copy Review Needs review of user-facing copy (language, phrasing) [Feature] History History, undo, redo, revisions, autosave. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 2, 2023
@jameskoster
Copy link
Contributor

It's strange to me that when the main Styles panel is open the 'document title' continues to display the template / page name. But then if you open revisions or the style book, it changes. Not to mention the awkward structure (a Panel titled "Styles" > "Revisions" within a view titled "Global Styles Revisions" 🙈). It would be good to explore these details more holistically soon, especially now that there is the Styles panel in the dark material as well.

But in the mean time I agree. Removing "Global", or even the entire title seems reasonable.

@annezazu annezazu mentioned this issue Jun 24, 2023
Closed
@jordesign
Copy link
Contributor

@annezazu This seems like a (hopefully) quick win to get into the other Style Variations work for 6.5?

annezazu added a commit that referenced this issue Jan 22, 2024
@annezazu
Update style revision top toolbar text
945e024 
Fixes #51202 by updating just the copy from "Global styles revisions" to "Style Revisions", matching what we show with "Style Book".
@annezazu annezazu mentioned this issue Jan 22, 2024
Merged
@annezazu
Copy link
Contributor Author

Kicked off a PR to maybe quickly fix this (assuming I did this correctly) 😜

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 22, 2024
richtabor added a commit that referenced this issue Jan 23, 2024
@annezazu @richtabor
Update Style Revision top toolbar text (#58057)
c9ce514 
* Update style revision top toolbar text

Fixes #51202 by updating just the copy from "Global styles revisions" to "Style Revisions", matching what we show with "Style Book".

* Styles Revisions -> Style Revisions

* Update test

---------

Co-authored-by: Rich Tabor <hi@richtabor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annezazu annezazu

Labels
[Feature] History History, undo, redo, revisions, autosave. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Copy Review Needs review of user-facing copy (language, phrasing) Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.
Projects
WordPress 6.5 Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update style revision top toolbar text WordPress/gutenberg
3 participants
@jameskoster @jordesign @annezazu