Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts: Add a description of the --no-watch option to the documentation #51695

Closed
t-hamano opened this issue Jun 20, 2023 · 6 comments
Closed

Scripts: Add a description of the --no-watch option to the documentation #51695

t-hamano opened this issue Jun 20, 2023 · 6 comments
Assignees
@Armondal
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Scripts /packages/scripts [Type] Developer Documentation Documentation for developers

Comments

@t-hamano
Copy link
Contributor

In #44237, the --no-watch option was added to the scripts command. However, it is not described in the README, so unless you discover the PR or read the code, you will not know this option exists.

It would be nice to add a description of this option in the README of the package.

It would also be better to update CHANGELOG as well. This PR was merged on February 2 and should be included in the version 25.4.0 section released on February 15.
@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers [Package] Scripts /packages/scripts Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Jun 20, 2023
@noahbcaldwell
Copy link
Contributor

I would like to be assigned to this issue!

@t-hamano
Copy link
Contributor Author

@noahbcaldwell

Thank you for your interest in this issue. You have been assigned 👍

@noahbcaldwell noahbcaldwell mentioned this issue Jun 20, 2023
Closed
@Armondal
Copy link
Contributor

As the issue is not solved yet. Can i also be assigned and submit a PR ?

@t-hamano
Copy link
Contributor Author

Hi @Armondal,

Thanks for your interest in this issue. It appears that #51707 has already been submitted for this issue, but it has not been merged yet. I would like to check on the status of #51707.

@t-hamano
Copy link
Contributor Author

@Armondal

I would like to assign you to this issue. Closed #51707 will be your reference when you submit your PR.

If a PR is submitted, happy to review it!

@t-hamano t-hamano assigned Armondal and unassigned noahbcaldwell Jul 28, 2023
@Armondal Armondal mentioned this issue Jul 29, 2023
Merged
@aurooba
Copy link
Member

aurooba commented Aug 24, 2023

Looks like this issue has been taken care of and I see a brief description of the --no-watch option in the documentation, closing it. Thanks for the addition @Armondal!

@aurooba aurooba closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Armondal Armondal

Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Scripts /packages/scripts [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aurooba @Armondal @t-hamano @noahbcaldwell