Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify documentation to include the scripts --no-watch option #51707

Conversation

noahbcaldwell
Copy link
Contributor

What?

Updating packages/scripts/README.md and packages/scripts/CHANGELOG.md to include information on the --no-watch option merged on February 2, 2023 and released in version 25.4.0

Why?

Adds missing documentation on the --no-watch option merged on February 2, 2023 and released in version 25.4.0. See #44237 and #51695.

How?

Minor changes to documentation

Testing Instructions

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 20, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @noahbcaldwell! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Jun 20, 2023
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncaldwe Thanks for your PR. Just one note below.

@@ -387,6 +387,7 @@ This script automatically use the optimized config but sometimes you may want to
- `--webpack-devtool` – controls how source maps are generated. See options at https://webpack.js.org/configuration/devtool/#devtool.
- `--webpack-no-externals` – disables scripts' assets generation, and omits the list of default externals.
- `--webpack-src-dir` – Allows customization of the source code directory. Default is `src`.
- `--no-watch` – Starts the build for development without starting the watcher.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these options should be in alphabetical order? This one for sure is not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely! Let me get right on that!

@t-hamano
Copy link
Contributor

Hi @ncaldwe,

Thank you for addressing this issue. Do you have time to continue working on this PR moving forward?

@noahbcaldwell
Copy link
Contributor Author

@t-hamano I do not. I am okay with this issue being reassigned

@t-hamano
Copy link
Contributor

@ncaldwe

Thanks for getting back to us. I just found someone who wants to work on this issue and would like to reassign it. Thanks for your contribution!

@t-hamano t-hamano closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Scripts /packages/scripts [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants