-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify documentation to include the scripts --no-watch option #51707
Modify documentation to include the scripts --no-watch option #51707
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @noahbcaldwell! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ncaldwe Thanks for your PR. Just one note below.
@@ -387,6 +387,7 @@ This script automatically use the optimized config but sometimes you may want to | |||
- `--webpack-devtool` – controls how source maps are generated. See options at https://webpack.js.org/configuration/devtool/#devtool. | |||
- `--webpack-no-externals` – disables scripts' assets generation, and omits the list of default externals. | |||
- `--webpack-src-dir` – Allows customization of the source code directory. Default is `src`. | |||
- `--no-watch` – Starts the build for development without starting the watcher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe these options should be in alphabetical order? This one for sure is not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely! Let me get right on that!
Hi @ncaldwe, Thank you for addressing this issue. Do you have time to continue working on this PR moving forward? |
@t-hamano I do not. I am okay with this issue being reassigned |
@ncaldwe Thanks for getting back to us. I just found someone who wants to work on this issue and would like to reassign it. Thanks for your contribution! |
What?
Updating packages/scripts/README.md and packages/scripts/CHANGELOG.md to include information on the
--no-watch
option merged on February 2, 2023 and released in version 25.4.0Why?
Adds missing documentation on the
--no-watch
option merged on February 2, 2023 and released in version 25.4.0. See #44237 and #51695.How?
Minor changes to documentation
Testing Instructions
start
section.