Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] fade animation #52347

Closed
github-actions bot opened this issue Jul 5, 2023 · 1 comment
Closed

[Flaky Test] fade animation #52347

github-actions bot opened this issue Jul 5, 2023 · 1 comment
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

fade animation

Test path

/test/e2e/specs/editor/blocks/image.spec.js

Errors

[2023-07-05T23:40:14.514Z] Test passed after 1 failed attempt on trunk.
[2023-07-06T01:46:45.389Z] Test passed after 1 failed attempt on fix/patterns-list-page-bugs.
[2023-07-06T02:12:13.604Z] Test passed after 1 failed attempt on fix/patterns-list-page-bugs.
[2023-07-07T00:20:48.189Z] Test passed after 1 failed attempt on update/minimal-npm-upgrade.
[2023-07-07T11:15:43.357Z] Test passed after 1 failed attempt on experiment/extend-behaviors-settings.
[2023-07-07T13:02:50.188Z] Test passed after 1 failed attempt on fix/resolver-resolution-status-key.
[2023-07-07T13:18:37.814Z] Test passed after 1 failed attempt on update/browserslist.
[2023-07-10T08:14:48.503Z] Test passed after 2 failed attempts on trunk.
[2023-07-10T08:55:27.584Z] Test passed after 2 failed attempts on trunk.
[2023-07-11T07:03:57.074Z] Test passed after 1 failed attempt on update/library-category-screen-reader.
[2023-07-11T11:47:22.366Z] Test passed after 1 failed attempt on rnmobile/move-undo-redo-buttons.
[2023-07-11T12:28:57.450Z] Test passed after 1 failed attempt on rnmobile/move-undo-redo-buttons.
[2023-07-11T17:09:30.561Z] Test passed after 1 failed attempt on remove/search-block-useEffects.
[2023-07-11T18:01:10.471Z] Test passed after 1 failed attempt on remove/search-block-useEffects.
[2023-07-11T23:41:09.335Z] Test passed after 1 failed attempt on rnmobile/docs/add-block-caption-readme.
[2023-07-12T16:33:26.396Z] Test passed after 1 failed attempt on release/16.2.
[2023-07-12T18:28:02.808Z] Test passed after 1 failed attempt on add-filter-to-switch-to-old-navigation-block-implementation.
[2023-07-13T11:31:21.500Z] Test passed after 1 failed attempt on rnmobile/update-mobile-toolbar-icons-and-color.
[2023-07-13T13:25:29.644Z] Test passed after 1 failed attempt on remove/REPLACE_INNER_BLOCKS.
[2023-07-13T14:49:54.152Z] Test passed after 1 failed attempt on remove/REPLACE_INNER_BLOCKS.
[2023-07-13T17:10:09.109Z] Test passed after 1 failed attempt on add/interactivity-api-feature-filter.
[2023-07-13T17:40:48.336Z] Test passed after 1 failed attempt on add/interactivity-api-feature-filter.
[2023-07-13T18:42:44.010Z] Test passed after 1 failed attempt on create-block-interactive-template-v2.
[2023-07-13T19:05:37.609Z] Test passed after 1 failed attempt on create-block-interactive-template-v2.
[2023-07-13T19:45:31.141Z] Test passed after 1 failed attempt on remove/search-block-useEffects.
[2023-07-13T22:47:25.895Z] Test passed after 1 failed attempt on fix-wp-data-promise-return-type.
[2023-07-14T01:05:10.965Z] Test passed after 1 failed attempt on fix-wp-data-promise-return-type.
[2023-07-14T10:58:01.844Z] Test passed after 1 failed attempt on fix/password-protected-input-field-no-autofocus.
[2023-07-14T14:24:13.544Z] Test passed after 1 failed attempt on fix/password-protected-input-field-no-autofocus.
[2023-07-14T16:57:02.086Z] Test passed after 1 failed attempt on trunk.
[2023-07-17T06:38:15.961Z] Test passed after 1 failed attempt on try/show-template-toggle.
[2023-07-17T16:31:01.242Z] Test passed after 1 failed attempt on fix/site-editor-code-editor-undo.
[2023-07-18T00:04:45.104Z] Test passed after 1 failed attempt on fix/template-part.
[2023-07-18T01:40:19.875Z] Test passed after 1 failed attempt on update/backport-footnote-trim-from-core.
[2023-07-18T03:05:28.860Z] Test passed after 1 failed attempt on update/backport-footnote-trim-from-core.
[2023-07-18T05:20:51.761Z] Test passed after 2 failed attempts on trunk.
[2023-07-18T12:33:38.343Z] Test passed after 1 failed attempt on enhancement/patterns-sticky-header.
[2023-07-19T12:48:14.331Z] Test passed after 1 failed attempt on trunk.
[2023-07-20T06:06:21.889Z] Test passed after 1 failed attempt on update/reinstate-template-parts-mode-spec.
[2023-07-20T06:34:29.691Z] Test passed after 1 failed attempt on update/reinstate-template-parts-mode-spec.
[2023-07-20T15:51:18.396Z] Test passed after 1 failed attempt on rnmobile/add/wp-hook-post-register-core-blocks.
[2023-07-20T16:38:43.081Z] Test passed after 1 failed attempt on rnmobile/add/wp-hook-post-register-core-blocks.
[2023-07-24T10:14:43.566Z] Test passed after 1 failed attempt on trunk.
[2023-07-24T13:12:49.989Z] Test passed after 1 failed attempt on fix/template-parts-mode-sidebar.
[2023-07-24T17:00:24.652Z] Test passed after 1 failed attempt on automation/a11y-label-consolidation.
[2023-07-24T17:38:37.255Z] Test passed after 1 failed attempt on automation/a11y-label-consolidation.
[2023-07-25T01:36:59.253Z] Test passed after 1 failed attempt on update/inserter-merge-patterns-tabs.
[2023-07-25T02:28:55.229Z] Test passed after 1 failed attempt on rnmobile/verse-block-soft-return.
[2023-07-25T05:47:05.099Z] Test passed after 1 failed attempt on trunk.
[2023-07-26T00:20:38.787Z] Test passed after 1 failed attempt on fix/patterns-filter-crash.
[2023-07-26T15:09:13.835Z] Test passed after 1 failed attempt on behaviors-in-site-editor-e2e-tests.
[2023-07-26T15:30:37.035Z] Test passed after 2 failed attempts on try/enforce-prs-use-pull_request_target.
[2023-07-27T06:20:54.591Z] Test passed after 2 failed attempts on try/footnotes-disallow-in-patterns-prevent-duplication.
[2023-07-27T07:30:08.069Z] Test passed after 2 failed attempts on trunk.
[2023-07-27T08:37:45.212Z] Test passed after 1 failed attempt on rnmobile/non-functioning-gallery-caption-button.
[2023-07-27T10:31:43.340Z] Test passed after 2 failed attempts on trunk.
[2023-07-27T10:36:52.413Z] Test passed after 1 failed attempt on fix/document-actions-get-label-helper.
[2023-07-27T11:09:36.653Z] Test passed after 2 failed attempts on trunk.
[2023-07-27T11:37:58.067Z] Test passed after 1 failed attempt on add/changelog-make-rnmobile-top-level-section.
[2023-07-27T16:03:25.850Z] Test passed after 1 failed attempt on docs/gb-release-images.
[2023-07-27T18:02:44.289Z] Test passed after 1 failed attempt on try/fonts-library-backend.
[2023-07-27T19:07:37.882Z] Test passed after 1 failed attempt on fix/document-actions-get-label-helper.
[2023-07-27T19:47:46.513Z] Test passed after 1 failed attempt on fix/document-actions-get-label-helper.
[2023-07-28T00:07:31.963Z] Test passed after 1 failed attempt on fix/footnotes-deep-nested.
Error: expect(received).toHaveAttribute(expected)

Expected pattern: /3b55ffed-ae90-4fb8-9cd4-d0fd40b3bca2/
Received string:  "blob:http://localhost:8889/b149b57c-d571-451c-bb0e-1c3e22ae4d98"
Call log:
  - expect.toHaveAttribute with timeout 5000ms
  - waiting for locator('role=document[name="Block: Image"i]').locator('role=img')
  -   locator resolved to <img alt="This image has an empty alt attribute" src=…/>
  -   unexpected value "blob:http://localhost:8889/b149b57c-d571-451c-bb0e-1c3e22ae4d98"
  - waiting for locator('role=document[name="Block: Image"i]').locator('role=img')
  -   locator resolved to <img alt="This image has an empty alt attribute" src=…/>
  -   unexpected value "blob:http://localhost:8889/b149b57c-d571-451c-bb0e-1c3e22ae4d98"
  -   locator resolved to <img alt="This image has an empty alt attribute" src=…/>
  -   unexpected value "blob:http://localhost:8889/b149b57c-d571-451c-bb0e-1c3e22ae4d98"
  -   locator resolved to <img alt="This image has an empty alt attribute" src=…/>
  -   unexpected value "blob:http://localhost:8889/b149b57c-d571-451c-bb0e-1c3e22ae4d98"
  -   locator resolved to <img alt="This image has an empty alt attribute" src=…/>
  -   unexpected value "blob:http://localhost:8889/b149b57c-d571-451c-bb0e-1c3e22ae4d98"
  -   locator resolved to <img alt="This image has an empty alt attribute" src=…/>
  -   unexpected value "blob:http://localhost:8889/b149b57c-d571-451c-bb0e-1c3e22ae4d98"
  -   locator resolved to <img alt="This image has an empty alt attribute" src=…/>
  -   unexpected value "blob:http://localhost:8889/b149b57c-d571-451c-bb0e-1c3e22ae4d98"
  -   locator resolved to <img alt="This image has an empty alt attribute" src=…/>
  -   unexpected value "blob:http://localhost:8889/b149b57c-d571-451c-bb0e-1c3e22ae4d98"
  -   locator resolved to <img alt="This image has an empty alt attribute" src=…/>
  -   unexpected value "blob:http://localhost:8889/b149b57c-d571-451c-bb0e-1c3e22ae4d98"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/image.spec.js:764:26
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Jul 5, 2023
github-actions bot referenced this issue Jul 12, 2023
* Trim footnote anchors from excerpts

* Add comments, fix spacing, appease linter
github-actions bot referenced this issue Jul 24, 2023
)

* Move `json_enconde` to the `echo` call inside `render`

* Escape tags and ampersands in WP_Interactivity_Store output

* Fix expected and add missing commas
github-actions bot referenced this issue Jul 27, 2023
* Check if spacing tool is defined before displaying controls.

* Don't show sides if spacing type false
github-actions bot referenced this issue Jul 27, 2023
* Upgrade `react-native` dependency

* Upgrade `@babel/runtime` dependency

* Upgrade `metro-react-native-babel` preset and transformer dependencies

* Upgrade `cocoapods` gem

* Re-apply `react-devtools-core` patch to new version

* Update jest snapshots with new a11y values

* Mock `Linking.addEventListener` function

`Linking.removeEventListener` has been removed in RN `0.71`. The library is mocked by default but doesn't return the `remove` function when calling `addEventListener`.

* Update tests that fail due to use of debounce and link suggestions

* Fix `MediaUpload` component test

* Update `@react-navigation/native` package to version `6.0.14`

* Update `react-native-reanimated` to version `2.17.0`

* Update `react-native-gesture-handler` to version `2.10.2`

* Fix `act` warnings produced during block insertion

* Fix `act` warnings in Columns block tests

* Fix `act` warnings in List block tests

* Upgrade `react-native` dependency to version `0.71.11`

It also upgrades `metro-react-native-babel` dependencies following the upgrade helper.

* Mock return value of Linking `addEventListener`

We only need to mock the return the value, hence we don't need to mock the entire library.

* Remove `waitForModalVisible` usage in Paragraph block tests

* Remove `waitFor` usage in Link settings tests

* test: Fix act warning by awaiting LinkPicker loading indicator removal

The loading indicator is displayed and subsequently removed once the
suggestion fetches resolve. Explicitly awaiting this element's removal
fixes the `act` warnings.

* build: Update react-native-safe-area-context to 4.6.3

* build: Upgrade react-native-screens to 3.22.0

* build: Upgrade react-native-svg to 13.9.0

Based on the release notes breaking changes, we should look out for odd
sizing or display of icons, particularly on Android.

* build: Upgrade @react-native-masked-view/masked-view to 0.2.9

* build: Upgrade @react-native-clipboard/clipboard to 1.11.2

* build: Upgrade react-native-modal to 13.0.1

* test: Update link modal snapshot

This change is a result of applying new props from the RN upgrade to a
newly introduced snapshot in trunk: 71d2dc5

* Update `@react-navigation/stack` to version `6.3.5`

* Upgrade `react-native-linear-gradient` to version `2.7.3`

This commit also updates the `react-native-hsv-color-picker` library to point to the same version of `react-native-linear-gradient`.

* Use `react-native-safe-area-context` mock provided by the library

* Update link modal snapshot

* Update `package-lock.json` file

The integrity checksum of `react-native-hsv-color-picker` changed because the package has been modified (ref: wordpress-mobile/react-native-hsv-color-picker#10 (comment))

* Disable `react-native-screens` in navigators

`react-native-screens` is meant to be used at root level to save memory when having inactive screens. This is not the case of the editor, as the stack navigators are used within the Bottom sheet component.
As a side note, enabling `react-native-screens` here leads to the editor crashing.

* Fix render order of animated view to highlight selected segment

Rendering the animated view before the segments will ensure that is rendered behind them.

* Update source of `react-native-hsv-color-picker` to use tag version

* Revert "Update link modal snapshot"

This reverts commit 7988b0e.

This is needed after disabling `react-native-screens` in navigators (ref: e5838f4).

* [RNMobile] Upgrade React Native `0.71.11` - iOS changes (#51386)

* refactor: Extract bundle version number to var

* refactor: Delete /.ruby-version, no longer needed

* refactor: Update /podfile to align w/RN updates

* refactor: Remove path names as part of RN upgrade

* Update `Podfile` with changes from RN upgrade helper

* Fix React Native path for `react_native_post_install` script

* Update Pods

* Add patch to fix Reanimated podspec

Without this patch, Reanimated tries to use Hermes version of React Native and produced a build failure. Seems there's an issue in the `podspec` file, as the JSC module is not being added.
Reference: software-mansion/react-native-reanimated#4254

* Update pods to reflect 0.71.11 target

* Apply changes to pods following `pod install`

* Update `Podfile.lock` file

---------

Co-authored-by: Siobhan <siobhan@automattic.com>

* [RNMobile] Upgrade React Native `0.71.11` - Android changes (#51289)

* Upgrade Gradle to version 7.5.1

* Upgrade Gradle plugin

* Remove no longer needed files in new version

* Update Flipper initialization

* Update demo project main application

* Remove gradle download task plugin

* Bump ndk version

* Remove no longer need logic related to `newArchEnabled`

* Apply plugin React Native Gradle plugin

* Use React Native and Hermes modules from Maven

We no longer need to publish these binaries because React Native team is publishing React Native binaries to Maven.

* Remove exclude group from Flipper

* Update comments in `build.gradle` to align with new RN version

* Remove deprecated Gradle property

* Add `mavenLocal` repository to allow testing local binaries

* Bump Reanimated and Gesture handler libraries

* Revert "Upgrade Gradle plugin"

This reverts commit 82764a2.

* build: Resolve react-native-gradle-plugin incompatability

Due to host app requirements, we must use AGP 7.2.1. The included patch
disables logic requiring AGP 7.3. The logic appears to not be required
for our use cases in the Demo editor or host apps.

We should remove this patch once we upgrade past AGP 7.3.

* Reduce priority of `mavenLocal` repository in Android build configurations

Maven local is used to provide dependencies located locally, which is mainly used for testing and debugging. Hence, published dependencies should be prioritized over local ones.

* Disable `react-native-screens` in navigators

`react-native-screens` is meant to be used at root level to save memory when having inactive screens. This is not the case of the editor, as the stack navigators are used within the Bottom sheet component.
As a side note, enabling `react-native-screens` here leads to the editor crashing.

* Fix render order of animated view to highlight selected segment

Rendering the animated view before the segments will ensure that is rendered behind them.

* Bump Linear gradient Android library

This library is now published via the `react-native-libraries-publisher` repository.

---------

Co-authored-by: David Calhoun <github@davidcalhoun.me>

* Avoid exception in E2E tests when typing an empty string on Android

* Update a11y id queries for Android E2E tests

Starting in React Native 0.71, the accessibility hint is no longer appended to the accessibility content description. Reference: facebook/react-native@0b70b38

* Update button inline appender query for Android E2E tests

* Unify press keycode function for E2E tests

* Update comments in functions related to pressing a keycode

* Update block drop position using Reanimated's shared value

Seems there's some kind of incompatibility on calling a JS function from a worklet invoked from a gesture handler. For this reason, the logic to set the dropping insertion point has been updated. It now uses a Reanimated's shared value to keep the dragging over position and  `useDerivedValue` hook to listen for changes.

* Remove unneeded `hidden` param in Paragraph block test case

Co-authored-by: David Calhoun <github@davidcalhoun.me>

* Revert removing `.ruby-version` file

* Add inline comment in Reanimated patch

* Use `waitForElementToBeRemoved` in Paragraph block test cases

This way we can avoid waiting for any microtasks of link suggestions.

* Remove `act` statements from Link Settings test cases

* fix: Cover focal point drag handle visibility

The lack of an explicit width or height resulted in a invisible drag
handle. The logic passing the dimensions to the SVG expected a single
style object. The reality is that it (1) referenced only the Sass styles
and (2) the combined reference was actually an array of style objects.

Updating the reference and flattening it ensures the appropriate width
and height are passed to the SVG.

It appears the absence of explicit dimensions was not an issue in
earlier versions of React Native, but it makes sense why it might be
required.

* [RNMobile] Use Reanimated in bottom sheet height animation (#52563)

* Expose max height properties in `BottomSheetProvider`

* Animate bottom sheet's height with Reanimated

Pass `currentHeight` in bottom sheet navigation context

* Use pixel value when setting fullscreen height

We need to pass pixel values in order to animate the height with Reanimated.

* Rename `heightRef` to `maxHeight`

* Re-enable `exhaustive-deps` lint rule in `BottomSheetNavigationContainer`

* Avoid setting height using debounce

* Add test ID to navigation container component

* Mock Reanimated's `now` function

* Update test cases related to bottom sheet height animation

* Update test snapshots

* Update `react-native-editor` changelog

* Drop unsupported `--no-jetifier` from Android cmd

The `--no-jetifier` option no longer appears to be supported and results in an error when attempting to build the Android demo app.

Ref: wordpress-mobile/gutenberg-mobile#5881 (comment)

* Revert accidental change to .ruby-version

* Restore correct dependencies to package-lock.json

* Update `react-native-editor` changelog

* Update `package-lock.json` file to revert previous conflict resolutions

In 4482b9d we had a conflict in `package-lock.json` that was solved using the changes from this branch. However, seems that something went wrong and that although the editor has no issues, some e2e tests are failing due to this.

This has been solved by using the latest version of `package-lock.json` file from `trunk` and updating it with the package updates required in the React Native upgrade.

* Re-apply `react-devtools-core` patch to new version

* Update `Podfile.lock` file

---------

Co-authored-by: David Calhoun <github@davidcalhoun.me>
Co-authored-by: Siobhan <siobhan@automattic.com>
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Aug 28, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

No branches or pull requests

0 participants