Distraction Free: Fix conflict with showListViewByDefault preference #52914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
@andrewserong Thanks for this PR! Should we do it in the site editor as well? |
Thanks for taking a look @ramonjd! This PR does it in the site editor, too, I was just lazy when it came to doing the screengrabs... I can add in some before/after pics 😄 Edit: Added to the PR description 👍 |
|
Size Change: +16 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
andrewserong
added
[Package] Edit Post
It wasn't you! I did "test" before asking, but I think my local dev hadn't built properly. Rebuilt. Works. 😆 |
Excellent, thanks for the speedy review! 🙇 |
andrewserong
deleted the
fix/distraction-free-mode-conflict-with-show-list-view-by-default
branch
ramonjd
added
the
Backport to WP Beta/RC
ramonjd
pushed a commit
that referenced
this pull request
Jul 25, 2023
|
I just cherry-picked this PR to the update/further-bugfixes-rc2 branch to get it included in the next release: c4c8306 |
ramonjd
removed
the
Backport to WP Beta/RC
ramonjd
added a commit
that referenced
this pull request
Jul 25, 2023
* Fix image block v6 deprecation (#52822) * Remove incorrect comment * Add missing attribtes and supports * Add integration tests for the deprecation * Fix incorrect import * Fix fixtures * Image: Use the correct method for caption class in recent deprecation (#52853) * Distraction Free: Fix notices in site editor (#52867) * Distraction Free: Add missing command in site editor (#52868) * Site Editor: Fix the template parts link on the list page (#52891) * Return focus more from focus return hook (#52710) * Disambiguate "Import" button string. (#52907) * Disambiguate "Import" button string. * Add _x to import --------- Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> * My patterns page: Increase color contrast for the toggle group (#52678) * Update style.scss * Update style.scss * Check if object exists before accessing its properties. (#52870) * Check if object exists before accessing its properties. * Name anonymous functions * Update names * Sidebar: Restore Back buton 'go to parent' functionality (#52910) * Global styles revisions: display text if no revisions are found (#52865) * If somehow a user lands on the revisions panel when there are no revisions, show some helpful text rather than a loading spinner. Also, add an E2E test! * Updated unit tests to reflect resolver logic changes * Use existing string * Only open edit view when testing the revisions panel itself * ResizableFrame: Account for window resizing (#52697) * ResizableFrame: Account for window resizing * Don't memoize --------- Co-authored-by: Robert Anderson <robert@noisysocks.com> * Distraction Free: Fix conflict with showListViewByDefault preference (#52914) * Backporting changes from WordPress/wordpress-develop#4891 * Site Editor: Open template parts in view canvas view mode (#52916) --------- Co-authored-by: Alex Lende <alex+github.com@lende.xyz> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net> Co-authored-by: Jb Audras <audrasjb@gmail.com> Co-authored-by: Carolina Nymark <myazalea@hotmail.com> Co-authored-by: Robert Anderson <robert@noisysocks.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: Lena Morita <lena@jaguchi.com> Co-authored-by: ramon <ramonjd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Check if distraction free mode is set before opening the list view by default.
Note: I'm not sure if this bug fix can make it in time for RCs, happy to punt it if there isn't enough time. I mostly noticed it because I usually have my editor set to show the list view by default.
Why?
While working on #52867 and #52868, I noticed that there is a conflict between the
showListViewByDefaultpreference and thedistractionFreemode. With Distraction Free mode, we expect that the list view will not be open, however theshowListViewByDefaultpreference doesn't currently take this into account.If you have
showListViewByDefaultset totrueand then switch to Distraction Free mode while in the post or site editors, everything appears to work as expected. However, if you reload the page, the list view will be open. This PR fixes it so that whendistractionFreeis set, we skip opening the list view by default.The approach in this PR preserves the
showListViewByDefaultpreference so that a user that toggles Distraction Free mode will be restored back to showing the list view by default once they switch off Distraction Free mode.How?
showListViewByDefaultpreference.Testing Instructions
SHIFT+CMD+\keyboard shortcut) to switch to distraction free mode.Screenshots or screencast
In the following screengrabs the
showListViewByDefaultsetting is set totrueand then the user enables distraction free mode, and then reloads the editor. In theBeforescreengrab, the list view is unexpectedly open.Site editor after reloading with
showListViewByDefaultset totrueas well asdistractionFree: