Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block mover icons miss reqiured attributes for accessibility #5247

Closed
afercia opened this issue Feb 25, 2018 · 0 comments · Fixed by #5263
Closed

Block mover icons miss reqiured attributes for accessibility #5247

afercia opened this issue Feb 25, 2018 · 0 comments · Fixed by #5263
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Feb 25, 2018

The block mover icons were refactored in #4631 and now a svg icon is passed directly as a prop.

The problem of passing icons this way is they lack the attributes aria-hidden="true" role="img" focusable="false"

All the Dashicons use these attributes by default. Also icons passed directly should use them.

One of the consequences is that without focusable="false" the icons are focusable in Internet Explorer so there's the need to tab twice when navigating with the keyboard.

Also, icons should be hidden from assistive technologies so they also use aria-hidden="true" role="img".

I'd suggest to consider a way to check for the presence of these attributes when passing icons directly.

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Feb 25, 2018
@youknowriad youknowriad self-assigned this Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants