Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

All the SVG icons need s focusable="false" attribute for IE11 #265

Closed
afercia opened this issue Oct 24, 2018 · 3 comments
Closed

All the SVG icons need s focusable="false" attribute for IE11 #265

afercia opened this issue Oct 24, 2018 · 3 comments
Labels
accessibility bug Something isn't working
Milestone

Comments

@afercia
Copy link

afercia commented Oct 24, 2018

See related issue / PR for Gutenberg

WordPress/gutenberg#1578
WordPress/gutenberg#2590

And following issues
WordPress/gutenberg#5247
WordPress/gutenberg#9269

In a few words:
IE 11 suffers from a bug where all SVG icons inside focusable elements default to focusable=”true”. As a consequence, both the wrapper focusable element and the inner SVG get focus and create a tab stop. To navigate with the keyboard through a button or a link which contain an SVG icon, there's the need to press Tab twice, which is something that should be definitely avoided.

As far as I see this would be a very quick change in TwentyNineteen_SVG_Icons::get_svg which already adds aria-hidden="true" role="img".

@kjellr kjellr added bug Something isn't working accessibility labels Oct 24, 2018
@kjellr kjellr added this to the RC1 milestone Oct 24, 2018
kjellr added a commit that referenced this issue Oct 24, 2018
@kjellr
Copy link
Collaborator

kjellr commented Oct 24, 2018

@afercia This should be handled via #272. Would you mind testing that out to verify that this change removes that tab stop?

Thanks!

@afercia
Copy link
Author

afercia commented Oct 24, 2018

@kjellr it does fix it thanks! 🎉

@kjellr
Copy link
Collaborator

kjellr commented Oct 24, 2018

Awesome, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants