Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@webpack-cli/generators@3.0.7 has some deprecated NPM modules #53552

Closed
stein2nd opened this issue Aug 11, 2023 · 4 comments · Fixed by #54657
Closed

@webpack-cli/generators@3.0.7 has some deprecated NPM modules #53552

stein2nd opened this issue Aug 11, 2023 · 4 comments · Fixed by #54657
Labels
Needs Dev Ready for, and needs developer efforts [Package] Scripts /packages/scripts [Type] Enhancement A suggestion for improvement.

Comments

@stein2nd
Copy link

stein2nd commented Aug 11, 2023

Description

When ncu was executed, @wordpress/scripts was displayed as ^26.9.0 → ^26.10.0, so ncu -u npm install was executed in sequence.
As a result, several npm modules were shown as deprecated as follows:

npm WARN deprecated debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.

npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm WARN deprecated @npmcli/move-file@1.1.2: This functionality has been moved to @npmcli/fs
npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs

These issues has been resolved in 3891, 3892, and 3893 reported in webpack-cli, so it is appropriate to replace it with the latest version.

Step-by-step reproduction instructions

  1. ncu
  2. ncu -u
  3. npm install

Screenshots, screen recording, code snippet

image

image

image

Environment info

System:

  • OS: macOS 13.5
  • CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  • Memory: 478.66 MB / 32.00 GB
  • Shell: 3.2.57 - /bin/bash

Binaries:

  • Node: 20.5.0 - ~/.nodebrew/current/bin/node
  • Yarn: 1.22.19 - /usr/local/bin/yarn
  • npm: 9.8.0 - ~/.nodebrew/current/bin/npm

npmPackages:

  • @webpack-cli/generators: ^3.0.7 => 3.0.7

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@gziolo gziolo added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention Needs Dev Ready for, and needs developer efforts [Package] Scripts /packages/scripts [Type] Enhancement A suggestion for improvement. and removed [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended labels Aug 11, 2023
@stein2nd
Copy link
Author

stein2nd commented Aug 19, 2023

After upgrading to @wordpress/scripts@26.11.0, we have confirmed that issue #53553 has been successfully resolved, but issue #53552 continues to occur.

Does this mean that this is happening because @webpack-cli/generators is not fixing its own deprecated issues webpack/webpack-cli#3891 with "debuglog", "readdir-scoped-modules", and "@npmcli/move-file"?

@gziolo
Copy link
Member

gziolo commented Sep 17, 2023

@stein2nd, thank you for the report. It looks like webpack-cli needs to be updated to the latest version. There were some breaking changes in v5.0.0, but they hopefully won't have impact.

@gziolo
Copy link
Member

gziolo commented Sep 20, 2023

I opened #54657 that might fix this issue.

@stein2nd
Copy link
Author

[@webpack-cli/generators@3.0.7] yeoman-environment has some deprecated packages.

  • debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
  • readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
  • @npmcli/move-file@1.1.2: This functionality has been moved to @npmcli/fs

Aren't these all because "yeoman-environment" is an older version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts [Package] Scripts /packages/scripts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants