-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duotone filter selector does not apply when using Image block alignment #54121
Comments
Seems to be a similar problem as in
|
#54099 is probably related to the missing styles in the latest plugin version, but not the bug first reported on Trac about the aligned images. The faulty CSS selector is a regression in WordPress 6.3, which might be fixable in a minor release. |
Thanks for reporting. I can confirm. Updating the issue labels. |
Noting for @ajlende in case you can share any insights! |
After a review by core editor triage leads and core editor tech leads, this has been removed from the board for 6.5 consideration. |
…ontainer in classic themes. Fixes #54121
…ontainer in classic themes (#59764) Co-authored-by: ajlende <ajlende@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: bph <bph@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: sabernhardt <sabernhardt@git.wordpress.org> * Add filter for duotone to account for gutenberg_restore_image_outer_container in classic themes. Fixes #54121 * Try making things a bit more efficient * Fix phpcs * Fix phpcs * Reuse if class_exists block * Fix phpcs
…ontainer in classic themes (WordPress#59764) Co-authored-by: ajlende <ajlende@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: bph <bph@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: sabernhardt <sabernhardt@git.wordpress.org> * Add filter for duotone to account for gutenberg_restore_image_outer_container in classic themes. Fixes WordPress#54121 * Try making things a bit more efficient * Fix phpcs * Fix phpcs * Reuse if class_exists block * Fix phpcs
Description
(reported earlier on Trac 59138)
Duotone filters seem to fail in any 'classic' theme when the image has an alignment class because the duotone classes are added to the
figure
element, and that is not the same as the.wp-block-image
element in classic themes. The selector in block.json expects both classes to be on the same element.Changing
.wp-block-image
to[class]
in that line of the block JSON worked for me in the bundled themes (Twenty Ten to Twenty Twenty-Three), though I do not know if the.wp-block-image
class was necessary somehow.Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
Image blocks with each alignment option, on the front end, with Twenty Seventeen
Environment info
WordPress 6.3 and 6.3.1, without the Gutenberg plugin
Windows 10, with both Firefox and Chrome
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: