Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pullquote: Unable to style the pullquote block #54554

Closed
hanneslsm opened this issue Sep 18, 2023 · 4 comments
Closed

Pullquote: Unable to style the pullquote block #54554

hanneslsm opened this issue Sep 18, 2023 · 4 comments
Labels
[Block] Pullquote Affects the Pullquote Block [Type] Bug An existing feature does not function as intended

Comments

@hanneslsm
Copy link

hanneslsm commented Sep 18, 2023

Description

This is the same issue as for the Code block: #54540
The settings from the theme.json are overwritten by the default styles

Step-by-step reproduction instructions

  1. Create a new theme
  2. Try to style the Pullquote block

Screenshots, screen recording, code snippet

      "core/pullquote": {
        "border": {
          "bottom": {
            "style": "none",
            "width": "0px"
          },
          "left": {
            "style": "none",
            "width": "0px"
          },
          "right": {
            "style": "none",
            "width": "0px"
          },
          "top": {
            "style": "none",
            "width": "0px"
          }
        }

image

Environment info

No response

Please confirm that you have searched existing issues in the repo.

No

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@hanneslsm
Copy link
Author

hanneslsm commented Sep 18, 2023

The cite element gets also overwritten in the pullquote (works in the block quote block)
Scratch that. It's possible to style the cite when not using the global one but the one within the pullquote.
image

@hanneslsm
Copy link
Author

hanneslsm commented Sep 18, 2023

I managed to remove the top and bottom border in the theme.json by adding

        "border": {
          "style": "none !important"
        },

Would be nice, if the !important wasn't needed in a theme.json, especially because it removes the possibility to add later custom borders via the UI.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Pullquote Affects the Pullquote Block labels Sep 19, 2023
@ramonjd
Copy link
Member

ramonjd commented Jan 28, 2024

@t-hamano
Copy link
Contributor

t-hamano commented Jun 1, 2024

@hanneslsm

Sorry for the late reply.

This problem does not seem to be reproducible in WP6.5 or the latest Gutenberg.

WP6.5:

pullquote

Latest Gutenberg:

pullquote_gutenberg

The theme.json I used for testing is below.

{
	"$schema": "../../schemas/json/theme.json",
	"version": 3,
	"settings": {
		"layout": {
			"contentSize": "840px",
			"wideSize": "1100px"
		}
	},
	"styles": {
		"blocks": {
			"core/pullquote": {
				"border": {
					"bottom": {
						"style": "none",
						"width": "0px"
					},
					"left": {
						"style": "none",
						"width": "0px"
					},
					"right": {
						"style": "none",
						"width": "0px"
					},
					"top": {
						"style": "none",
						"width": "0px"
					}
				}
			}
		}
	}
}

I would like to close this issue, but if the problem still exists, please feel free to comment.

@t-hamano t-hamano closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pullquote Affects the Pullquote Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants