Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pullquote block overrides global theme.json settings for borders #56628

Open
carolinan opened this issue Nov 29, 2023 · 0 comments
Open

Pullquote block overrides global theme.json settings for borders #56628

carolinan opened this issue Nov 29, 2023 · 0 comments
Labels
[Block] Pullquote Affects the Pullquote Block [Type] Bug An existing feature does not function as intended

Comments

@carolinan
Copy link
Contributor

Description

If I want to disable all border settings using theme.json, according to the documentation, I should use:


{
	"version": 2,
	"settings": {
		"border": {
			"color": false,
			"radius": false,
			"style": false,
			"width": false
		}
	}
}

This correctly disables the border settings for some blocks, like the group.
But it does not disable any border settings for the pullquote block.

If I instead use :

{
	"version": 2,
	"settings": {
		"border": {
			"color": false,
			"radius": false,
			"style": false,
			"width": false
		},
		"blocks": {
			"core/pullquote": {
				"border": {
					"color": false,
					"radius": false,
					"style": false,
					"width": false
				}
			}
		}
	}
}

Then the border setting is hidden also for the pullquote block.

Step-by-step reproduction instructions

Open the theme.json of any block theme, delete everything in the file, and copy paste the first example from the issue.
Activate the theme.
Open the block editor or site editor and add a pullquote block.
Confirm that the block still has border options.
Repeat the steps with the second code example, and confirm that the block no longer has a border options.

Screenshots, screen recording, code snippet

No response

Environment info

WordPress 6.4.1. Gutenberg is not active.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@carolinan carolinan added [Type] Bug An existing feature does not function as intended [Block] Pullquote Affects the Pullquote Block labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pullquote Affects the Pullquote Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant