Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data views: Pagination #55095

Closed
jameskoster opened this issue Oct 5, 2023 · 4 comments
Closed

Data views: Pagination #55095

jameskoster opened this issue Oct 5, 2023 · 4 comments
Assignees
@ntsekouras
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Oct 5, 2023 •
edited

This ticket is a stub to include designs for navigating through multiple pages within data views. Considerations include:

  • Positioning (above/below table, pinned/sticky, etc)
  • Optimising the overall footprint accounting for tables with many pages
  • Quick-navigation to specific page numbers
  • Quick-navigation to first/last pages
  • Total number of records in current page, and total number of overall records, total number of pages
  • Potential inclusion of records-per-page option (overlaps with Data views: View options #55094)
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. labels Oct 5, 2023
@jameskoster jameskoster mentioned this issue Oct 5, 2023
Closed
16 tasks
@youknowriad youknowriad mentioned this issue Oct 5, 2023
Open
@annezazu annezazu added the [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond label Oct 9, 2023
@ntsekouras
Copy link
Contributor

What is needed to change based on the current status of the pagination? As some tasks like quick navigation are already in, do we need to update the design? Do we have a mockup?

@jameskoster
Copy link
Contributor Author

Quick jumping to specific pages isn't working for me currently 🤔

Some changes we can try:

  • Make the pagination row sticky at the bottom of the view
  • Use icons instead of plain text for buttons
    • Next: chevronRight
    • Previous: chevronLeft
    • First: previous
    • Last: next

Then there are some cosmetic adjustments; typography, colors, spacing, etc. I'll work on a PR for that as time allows.

@ntsekouras ntsekouras self-assigned this Oct 16, 2023
This was referenced Oct 16, 2023
Merged
Merged
@jameskoster jameskoster changed the title Table: Pagination Data views: Pagination Oct 18, 2023
@ntsekouras
Copy link
Contributor

ntsekouras commented Oct 30, 2023 •
edited

I think the only remaining thing for now is:

Positioning (above/below table, pinned/sticky, etc)

Pagination is now at the bottom of the frame at all times. We could add the option to place it above, but since there are no current use cases/designs for that, should we close this? We can always add it when we need to.

@jameskoster
Copy link
Contributor Author

Yes, let's close this 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntsekouras ntsekouras

Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jameskoster @ntsekouras @annezazu