[Data views]: Update icons and design tweaks #55391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
Size Change: -7 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
update/dataviews-pagination-design-tweaks
branch
from
a6793a7
to
c4392fd
Compare
This doesn't seem to be working for me: 
I'll push some general styling tweaks shortly. |
It's sticky if the list is bigger than the container. You meant in general in the bottom? |
|
Yes. It would be nice to avoid the buttons jumping around as you navigate, and sticking the pagination row to the bottom of the frame would eliminate that. |
|
@ntsekouras I think we can remove the Rows per page option from the pagination row. It's not an affordance folks generally interact with frequently, so having it permanently visible in the table footer feels overly emphasised. It's only two clicks away in the main View menu which seems adequate. Would it make sense to do this here or separately? |
ntsekouras
force-pushed
the
update/dataviews-pagination-design-tweaks
branch
from
cc33429
to
8d04537
Compare
The fields list in the "grid" view is broken now. I'm not sure if it's due to this PR or the one that introduced "primary" / "secondary" actions. I also wonder whether all actions should be considered "secondary" in the grid view. |
youknowriad
reviewed
Oct 30, 2023
| @@ -1,6 +1,16 @@ | |||
| .dataviews-wrapper { | |||
| width: 100%; | |||
| min-height: calc(100% - 60px); | |||
There was a problem hiding this comment.
The 60px is not part of the data views component, so it seems it's not something we should be applying to .dataviews-wrapper instead maybe it should apply to the current usage of DataViews in the page-pages component.
There was a problem hiding this comment.
Good call. Actually it seem I had this change before the overflow rule. It seems the calc is not needed any more.
youknowriad
reviewed
Oct 30, 2023
| @@ -1,6 +1,16 @@ | |||
| .dataviews-wrapper { | |||
| width: 100%; | |||
| min-height: calc(100% - 60px); | |||
| overflow: auto; | |||
There was a problem hiding this comment.
Was this one necessary?
There was a problem hiding this comment.
I think so, yes. Without it, if the list is bigger than the frame's height, it will still scroll but not get the right padding applied to this container and results in having the pagination at the bottom without it. I'm not sure if I could use a better css rule..
This is not from this PR, but will push a fix for this here. I just have to wrap it with |
|
Flaky tests detected in 14767da. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6690355211
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #55095
This PR:
We can also add in this PR any other design tweaks we want in order to close the linked issue for now.
Screen.Recording.2023-10-30.at.10.04.52.AM.mov