Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The new Welcome Guide in the Site Editor makes some wrong assumptions and gives bad info for hybrid themes #55857

Closed
MadtownLems opened this issue Nov 3, 2023 · 1 comment · Fixed by #55865
Closed

The new Welcome Guide in the Site Editor makes some wrong assumptions and gives bad info for hybrid themes #55857

MadtownLems opened this issue Nov 3, 2023 · 1 comment · Fixed by #55865
Assignees
@t-hamano
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@MadtownLems
Copy link

Description

I'm testing out 6.4-RC-3 with our hybrid theme (not FSE, just has a few Template Parts).

When I booted up a Template Part to edit, I was shown an "Edit your site" modal popup that is not applicable to our type of theme at all.

"Design everything on your site - from the header right down to the footer - using blocks"

Our users aren't able to do that. Template Parts just control very small bits of the site.

"Click (split circle icon) to start designing your blocks..."

We don't have that icon, again because this is just for Template Parts, not FSE.

Step-by-step reproduction instructions

  1. Load a theme that uses Template Parts, but not FSE
  2. Edit a Template Part
  3. See the Welcome Guide popup that would be very confusing in hybrid themes

Screenshots, screen recording, code snippet

No response

Environment info

WP 6.4-RC-3

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@t-hamano t-hamano added Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Nov 5, 2023
@t-hamano t-hamano mentioned this issue Nov 5, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 5, 2023
@jordesign jordesign added the [Type] Bug An existing feature does not function as intended label Nov 5, 2023
@mrwweb
Copy link

mrwweb commented Nov 28, 2023

Confirming this issue. Hybrid theme with theme.json and template parts support on WP 6.4.1.

Here's the welcome screen:

the template parts editor is darkened with a modal above it reading "Edit your site" with details about the site editor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-hamano t-hamano

Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Site Editor: Don't display welcome guide in hybrid theme WordPress/gutenberg
4 participants
@MadtownLems @mrwweb @jordesign @t-hamano