Site Editor: Don't display welcome guide in hybrid theme #55865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
Backwards Compatibility
|
Size Change: +83 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
t-hamano
force-pushed
the
welcome-guide-hybrid-theme
branch
from
7e19f3d
to
de6b5e3
Compare
t-hamano
force-pushed
the
welcome-guide-hybrid-theme
branch
from
de6b5e3
to
e8c9208
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Awesome - thank you! Note that I did just link my wordpress.org and github profiles, per the comment from github-actions. I don't believe I have the ability to add the props-bot label, though. |
Mamaduka
approved these changes
Mar 18, 2024
|
@Mamaduka Thanks for te review! |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…5865) * Site Editor: Don't display welcome guide in hybrid theme * Add e2e test Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: MadtownLems <madtownlems@git.wordpress.org> Co-authored-by: mrwweb <mrwweb@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55857
What?
This PR prevents classic themes with
block-template-partssupport from displaying the welcome guide when opening the template parts editor.Why?
Everything explained in the welcome guide is related to block themes. With hybrid themes, you cannot edit the entire site, and you cannot use the global style UI.
How?
If it is not a block theme, the welcome guide will not be displayed. In the Site Editor, there are also welcome guides related to Templates, Global Styles and Pages, but if the current theme is not a block theme, you should not be able to access these pages in the first place.
Testing Instructions
Note: If you have previously hidden the Welcome Guide, please follow the steps below to reset your test environment (
localhost:8889) settings.Delete the preference from database:
Delete
WP_PREFERENCES_USER_Xfrom the browser's local storage:http://localhost:8889/wp-admin/.e2e test
packages/edit-site/src/components/welcome-guide/editor.jsfile to the trunk version.npm run test:e2e:playwright test/e2e/specs/site-editor/hybrid-theme.spec.js