Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not padding Frequent tab with blocks that are in common category #5627

Closed
maddisondesigns opened this issue Mar 15, 2018 · 8 comments · Fixed by #5969
Closed

Consider not padding Frequent tab with blocks that are in common category #5627

maddisondesigns opened this issue Mar 15, 2018 · 8 comments · Fixed by #5969
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface
Milestone

Comments

@maddisondesigns
Copy link

Issue Overview

Creating a new issue because you haven't re-opened the previous one you closed (#3737)

The Frequent blocks tab is showing blocks that I've never used. Even after inserting a single Paragraph block, the Frequent Tab (formerly Recent Tab), is showing Paragraph, Columns, Image, Cover Image, Gallery, Heading, Quote, Audio and Button blocks.

What is the point of having a Frequent Tab if it simply shows a bunch of random blocks that I haven't even used on the page? If you're just going to add random blocks then why bother having this tab at all?

gutenberg-frequentblocks

More details can be found on the previous issue raised #3737

Steps to Reproduce (for bugs)

  1. Create new Post/Page
  2. Insert single Paragraph block
  3. View Inserter menu and switch to Frequent tab
  4. Frequent tab is filled with blocks you haven't used

Expected Behavior

I expect the Frequent tab to only show blocks that been most frequently used. If I've only used one Block, how can it show all these other blocks as been used frequently?

Current Behavior

Frequent Tab shows random blocks I've never used on the page

Possible Solution

Only show the blocks I've actually used, and list them in the most frequently used order.

Related Issues and/or PRs

#3737

Gutenberg 2.4.0
Firefox Quantum 58.0.2 (64-bit)

@jeffpaul jeffpaul added [Type] Enhancement A suggestion for improvement. [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Mar 21, 2018
@karmatosed
Copy link
Member

Interesting find and I think potentially a bug. I just looked at mine and it seems to not be weighting frequency correctly for me either:

2018-03-21 at 22 35

I am going to change this to a bug as it should absolutely frequent frequent uses. @noisysocks is there a potential this is a change based on the work for the suggested blocks? I would say the frequency in the library should remain untouched.

@karmatosed karmatosed added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Mar 21, 2018
@karmatosed karmatosed added this to the Merge Proposal milestone Mar 21, 2018
@noisysocks
Copy link
Member

noisysocks commented Mar 22, 2018

Both the Frequent tab in the inserter and the suggested block icons at the bottom of the page use the same algorithm to calculate the list of blocks to suggest.

The algorithm picks nine blocks that the user has used, ordered by a heuristic that weighs both how recently the block was used and how frequently the block was used (see #5342).

If less than nine blocks have been used, however, then the list of blocks is padded with blocks that are in the common category. This ensures that a user who is opening Gutenberg for the first time always sees nine blocks in the Frequent tab. This is why there are "random blocks" appearing in the tab.

Hope that explanation helps. I'm going to close this bug issue since technically everything mentioned in this thread is working as intended. Happy to discuss ideas for improving this, though.

@maddisondesigns
Copy link
Author

@noisysocks As I mentioned above, what is the point of having a Frequent Tab if it simply shows a bunch of random blocks that I haven't even used on the page? You may as well just get rid of this tab altogether. By auto-populating this tab so there's 9 blocks means your forcing a users eyes to do more work, scanning through all the blocks, than what they would if it only showed the few blocks that they'd actually used.

When I'm selecting fonts in Microsoft Word, it separates your recently used fonts at the top of the menu, for easy selection. It doesn't automatically add in a bunch of extra common or adhoc fonts, it only shows the ones that I've used. If I've used one font, it only shows one font. If I've used 5, it'll show 5. This is what people are used to.

gutenberg-recentwordfonts

Can you please reopen this while the discussion is ongoing.

@noisysocks noisysocks changed the title Frequent blocks showing blocks that I've never used Consider not padding Frequent tab with blocks that are in common category Mar 22, 2018
@noisysocks noisysocks added Needs Design Feedback Needs general design feedback. and removed [Type] Bug An existing feature does not function as intended labels Mar 22, 2018
@noisysocks
Copy link
Member

noisysocks commented Mar 22, 2018

As I mentioned above, what is the point of having a Frequent Tab if it simply shows a bunch of random blocks that I haven't even used on the page?

I personally think that it's nice that a brand new user is presented with common blocks rather than a blank tab or the fairly overwhelming Blocks tab.

cc. @jasmussen and @mtias for design input. #2551 raised a very similar concern regarding the usefulness of a Frequent/Recent tab. I think that it's difficult to decide on this one way or another in the absence of data e.g. from performing user testing on this tab.

For context, #1694 is what introduced this padding behaviour.

@noisysocks noisysocks reopened this Mar 22, 2018
@maddisondesigns
Copy link
Author

I personally think that it's nice that a brand new user is presented with common blocks rather than a blank tab or the fairly overwhelming Blocks tab.

As @karmatosed mentioned on #2551, one solution would be to reorder the tabs so that the Frequent tab is last, rather than first.

I think another option would be to simply make the Blocks tab the default, on new pages. That is, if you've just created a new page and clicked the inserter menu for the first time, make the Blocks tab the default, rather than the Frequent tab. This way you could leave the order of the tabs as they are.

When you're editing an existing page (as opposed to creating a new page), you could leave the Frequent tab as the default as it's more than likely going to show a few different blocks in it anyway.

@jasmussen
Copy link
Contributor

There is certainly merit in honing and polishing the Inserter, and how frequency is created.

I can also see why it would make sense to show as few blocks as possible, on a completely fresh install, and then let the tab be populated as a user starts using blocks. For example it could have Image, Heading, Gallery, perhaps List, and no more.

However I'd be careful to do too many changes to the Inserter in this stage of the Gutenberg project — we need to wrap things up, and also leave some improvements for the next team working on the Gutenberg Customization focus.

Meta-note, please: no-one should take offense at tickets getting closed. The discussion is not closed, and as is evident from this discussion, tickets can be reopened.

@karmatosed
Copy link
Member

karmatosed commented Mar 22, 2018

I actually think we could do 2 things here. As they are 2 distinct places we could ask why should they show the same things.

  • Frequent tab be empty for new users and add as you use them. Maybe we also don't even show frequent to new users, that's a sound option too.
  • Suggested block icons: have algorithm.

Aside from this we really do need to consider is frequent the right name once it is being used.

Now, the issue with that is an empty tab, maybe we add a message for new users. This is what I expected to happen, which is why I also thought this was a bug. It's interesting that it may be what others expect. My focus was on the suggested blocks in the iterations before, therefore assuming they weren't linked. Apologies for getting us off track there. I'm also happy we just ship as is now and then iterate if we get more feedback like this. It's good to think about.

Even later I maybe wonder if we don't swap out Frequent in the library for something like favourites. It's a possibility.

I would add that we totally should be ok closing issues yet continuing discussion.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Mar 27, 2018
@noisysocks
Copy link
Member

In the short term, I think we should rename the tab to Suggested. This is an easy change that hopefully will prevent confusion about why the default inserter tab displays blocks that haven't been used.

In the medium term, we can look into alternative designs for the default inserter tab based on feedback we get from the community and user testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants