Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Palette: No longer closes on Escape key #59080

Closed
mirka opened this issue Feb 15, 2024 · 3 comments
Closed

Command Palette: No longer closes on Escape key #59080

mirka opened this issue Feb 15, 2024 · 3 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Commands /packages/commands [Type] Bug An existing feature does not function as intended

Comments

@mirka
Copy link
Member

mirka commented Feb 15, 2024

The Command Palette used to close on Esc, as can be observed in the WP Playground for WP 6.4. This is no longer the case in trunk.

Steps to reproduce

  1. In the post editor, invoke the Command Palette (⌘K).
  2. Hit Esc.

Expected behavior

The Command Palette closes.

Actual behavior

The Command Palette doesn't close.

@mirka mirka added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Commands /packages/commands labels Feb 15, 2024
@t-hamano
Copy link
Contributor

As the screenshot below shows, I was unable to reproduce it in my environment. IME input also seems to be handled properly.

8fa6f0708b7f2933e40ba0d2ae687ffd.mp4

Which OS/browser is this issue occurring on? I tested in the following environment.

  • OS: Windows OS
  • WordPress Version: WordPress 6.5-beta1-57631
  • Gutenberg Version: 17.7.0 (trunk)
  • Browser: Chrome 121.0.6167.162, Firefox 122.0.1

@mirka
Copy link
Member Author

mirka commented Feb 16, 2024

I did some more testing. With WP Playground 6.5-beta1 on a Mac, the bug reproduces in Chrome but not in Safari/Firefox. However, I tried again with an Incognito tab and also on a different Mac (with different Chrome settings), and it did not reproduce.

It's just my specific Chrome setup that somehow exhibits this difference between WP 6.4 and 6.5 beta 😅 I have no idea what it is, but I'm going to have to close this as something on my end.

Thanks for testing!

@mirka mirka closed this as completed Feb 16, 2024
@mirka
Copy link
Member Author

mirka commented Feb 16, 2024

Noting for anyone who sees this same issue — the culprit for me was the Vimium extension for Chrome. You will need to add disable URL rules for anywhere you use wp-admin on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Commands /packages/commands [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants