Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cherry Pick script to include all PRs #59210

Closed
getdave opened this issue Feb 20, 2024 · 0 comments · Fixed by #59871
Closed

Fix Cherry Pick script to include all PRs #59210

getdave opened this issue Feb 20, 2024 · 0 comments · Fixed by #59871
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling

Comments

@getdave
Copy link
Contributor

getdave commented Feb 20, 2024

During the Beta 2 for WordPress 5.6, 22 PRs were missed by the automated cherry picking script

npm run cherry-pick

@youknowriad and I believe this is because by default the Github paginates its REST API results. It defaults to 30 items per day (see per_page). Therefore if the number of PRs to be commit exceeds this default then it will miss PRs outside the first "page" of results.

To avoid this happening we should do two things:

  • update the release documentation to add a "confidence check" step following running of the cherry pick script to manually check that all relevant PRs were picked correctly.
  • Update the cherry pick script to utilise pagination as per the Github API guidance.
@getdave getdave added the [Type] Bug An existing feature does not function as intended label Feb 20, 2024
@jordesign jordesign added the [Type] Build Tooling Issues or PRs related to build tooling label Feb 21, 2024
@getdave getdave changed the title Improve PR Cherry Picking Script Fix Cherry Pick script to include all PRs Feb 27, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants