Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve likelihood of Cherry Picking script including all PRs #59871

Merged
merged 1 commit into from Mar 14, 2024

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Mar 14, 2024

What?

Improves the liklihood that the Cherry Picking script will fetch all the PRs that need to be cherry picked.

Closes #59210

Why?

The Github API paginates it's results with a default of 30. It is possible that for a given release there will be more than 30 PRs that need to be picked into the relevant release branch.

This needs fixing so that future release leads don't end up missing PRs. I already updated the release docs with this extra warning but it makes sense to also improve the tooling.

How?

Adds the per_page param to the request and sets it to 100.

I see this as a "good enough" fix. If there are more than 100 PRs in a given release we have a bigger problem 😆

Testing Instructions

  • We can run the script passing a label we know will have a lot of PRs. This is to simulate testing for a release where lots of PRs are labeled with the default label.
  • Do not propagate the results to Github - you can say "no" when prompted to avoid this.
  • Run npm run other:cherry-pick -- "[Type] Bug".
  • Check that more than 30 PRs are found.

Testing Instructions for Keyboard

Screenshots or screencast

@getdave getdave added [Type] Enhancement A suggestion for improvement. Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Mar 14, 2024
@getdave getdave self-assigned this Mar 14, 2024
Copy link

github-actions bot commented Mar 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me. Thanks.

@getdave getdave merged commit 3706a2f into trunk Mar 14, 2024
65 checks passed
@getdave getdave deleted the fix/cherry-picking-script-missing-commits branch March 14, 2024 13:35
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 14, 2024
@bph bph added [Type] Build Tooling Issues or PRs related to build tooling and removed [Type] Enhancement A suggestion for improvement. labels Mar 21, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Build Tooling Issues or PRs related to build tooling
Projects
Development

Successfully merging this pull request may close these issues.

Fix Cherry Pick script to include all PRs
3 participants