Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in pagination strings: CurrenPageControl rather than CurrentPageControl #59652

Closed
peterwilsoncc opened this issue Mar 7, 2024 · 1 comment · Fixed by #59656
Closed
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended [Type] Code Quality Issues or PRs that relate to code quality

Comments

@peterwilsoncc
Copy link
Contributor

peterwilsoncc commented Mar 7, 2024

Description

Props due @BronsonQuick Bronson Quick <bronsonquick@git.wordpress.org>

In both the dataviews and font-collection pagination strings there are typoed component names <CurrenPageControl />.
This could lead to confusion for translators presuming the string is a typo and fixing it.

data views:

{ createInterpolateElement(
sprintf(
// translators: %s: Total number of pages.
_x( 'Page <CurrenPageControl /> of %s', 'paging' ),
totalPages
),
{
CurrenPageControl: (

font collection:

{ createInterpolateElement(
sprintf(
// translators: %s: Total number of pages.
_x(
'Page <CurrenPageControl /> of %s',
'paging'
),
totalPages
),
{
CurrenPageControl: (

Step-by-step reproduction instructions

N/A: typo rather than code bug

Screenshots, screen recording, code snippet

See above

Environment info

Gutenberg trunk @ 0f37efd
WordPress develop trunk @ https://github.com/wordpress/wordpress-develop/commits/f3e19bf56608e80952a71e77691bdd5aab315548
WordPress develop 6.5 @ https://github.com/wordpress/wordpress-develop/commits/0c1507c2e66a5109db1ed50626176774b8bcb08e

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@peterwilsoncc peterwilsoncc added the [Type] Bug An existing feature does not function as intended label Mar 7, 2024
@t-hamano t-hamano added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Code Quality Issues or PRs that relate to code quality [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels Mar 7, 2024
@rcoll
Copy link
Contributor

rcoll commented Mar 7, 2024

Cheers. I think this PR fixes the issue #59656.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants