Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Dataviews and Font Collection packages #59656

Merged
merged 1 commit into from Mar 7, 2024

Conversation

rcoll
Copy link
Contributor

@rcoll rcoll commented Mar 7, 2024

What?

This PR fixes the typoed component names in dataviews and font-collection.

Why?

As reported in #59652, these typos could lead to confusion for translators.

How?

Simple typo fixes.

Testing Instructions

There's not much to do here other than review the code and make sure nothing obvious breaks when building and testing. The experience should remain unchanged.

Screenshots or screencast

Copy link

github-actions bot commented Mar 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @rdcoll@odyssey.local.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: rdcoll@odyssey.local.

Co-authored-by: rcoll <rdcoll@git.wordpress.org>
Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@rcoll rcoll changed the title Fix typo in Dataviews Pagination and Font Collection components Fix typo in Dataviews and Font Collection packages Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @rcoll! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 7, 2024
@peterwilsoncc peterwilsoncc added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 7, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 7, 2024
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rcoll, I've confirmed this fixes all instances.

I've approved the PR and will merge it once all the tests finish running.

@peterwilsoncc peterwilsoncc added the [Type] Bug An existing feature does not function as intended label Mar 7, 2024
@peterwilsoncc peterwilsoncc merged commit 9888332 into WordPress:trunk Mar 7, 2024
60 of 61 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 7, 2024
@peterwilsoncc peterwilsoncc added [Type] Code Quality Issues or PRs that relate to code quality Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta and removed [Type] Bug An existing feature does not function as intended labels Mar 7, 2024
@peterwilsoncc
Copy link
Contributor

I've applied the backport label to this PR. Although Core is in string freeze, the fixing of typos is permitted as they are string errors.

getdave pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: rcoll <rdcoll@git.wordpress.org>
@getdave
Copy link
Contributor

getdave commented Mar 11, 2024

I just cherry-picked this PR to the pick/wp-65-rc-2 branch to get it included in the next release: 4958400

@getdave getdave added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Mar 11, 2024
getdave pushed a commit that referenced this pull request Mar 12, 2024
Co-authored-by: rcoll <rdcoll@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Code Quality Issues or PRs that relate to code quality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Typo in pagination strings: CurrenPageControl rather than CurrentPageControl
3 participants