Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation links: add the link target settings to the block inspector #59994

Open
afercia opened this issue Mar 19, 2024 · 1 comment · May be fixed by #60132
Open

Navigation links: add the link target settings to the block inspector #59994

afercia opened this issue Mar 19, 2024 · 1 comment · May be fixed by #60132
Assignees
Labels
[Block] Navigation Link Affects the Navigation Link Block [Feature] Navigation Menus Any issue relating to Navigation Menus Needs Design Feedback Needs general design feedback. [Package] Block editor /packages/block-editor [Package] Block library /packages/block-library [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Mar 19, 2024

Description

While editiing navigation links and submenus I noticed the 'link target' setting is only available in the link editing UI popover, while it is absent in the block inspector.

As a user, this is confusing to me. I would expect the block inspector settings panel to let me access all settings ot a block.

For consistency, I'd suggest to add it to the 'Advanced' section of the block inspector.

Screenshot: Observe the link target settings is only available in the the link editing UI popover:

Screenshot 2024-03-19 at 15 02 34

Step-by-step reproduction instructions

  • Go to the Site editor > Design > Navigation > any menu.
  • Make sure the settings panel is open.
  • Click on a navigation link or submenu to select it.
  • In the settings panel, expand the 'Advanced' section.
  • Click 'Link' in the block toolbar and then click the 'Edit link' pencil icon button to open the link editing UI popover.
  • Observe the open popover and observe the open Settings panel.
  • Onserve the link target setting is only available in the popover.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Package] Block library /packages/block-library [Package] Block editor /packages/block-editor [Block] Navigation Link Affects the Navigation Link Block [Feature] Navigation Menus Any issue relating to Navigation Menus labels Mar 19, 2024
@jasmussen
Copy link
Contributor

Can we just duplicate the entire "Advanced" section verbatim into the inspector?

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Link Affects the Navigation Link Block [Feature] Navigation Menus Any issue relating to Navigation Menus Needs Design Feedback Needs general design feedback. [Package] Block editor /packages/block-editor [Package] Block library /packages/block-library [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants