Add ToggleControl for "Open in new tab" in Settings. #60132
+35
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torounit
added
[Block] Navigation Link
|
Size Change: +20 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thank you for the PR! In #59994 (comment) I suggesed copying the entire "advanced" section fro the link dialog into the inspector. That means including the chevron to expand/collapse, including the checkbox. Would it be possible to work in that direction? |
|
@jasmussen Thank you for reviewing! Of course, this toggle button can also be moved to the "Advanced" section. In the I thought it would be a bit confusing to have this feature in the "Advanced" section only in the navigation block. What do you think about this? |
|
Oh I didn't mean the Advanced section of the inspector. I meant transplanting the chevron based toggle from here:
to here:
Quick sketch: 
I can see how seeing "Advanced" twice in that panel is a bit much, especially since things like role and rel are also, arguably, advanced. The suggestion here was mainly in case it was an easier fix. Alternately, you can omit the extra collapsing, but I'd still keep it a checkbox, and show it after text and link fields, like so: Let me know how that sounds. |
|
@jasmussen I see. This looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add "Open new tab" ToggleControl to the
core/navigation-linkandcore/navigation-submenublock inspectors.Why?
fix: #59994
How?
ToggleControl was used as in core/post-title.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
2024-03-23.3.33.44.mov