Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking template when on page #60011

Closed
SaxonF opened this issue Mar 20, 2024 · 2 comments · Fixed by #60016
Closed

Clicking template when on page #60011

SaxonF opened this issue Mar 20, 2024 · 2 comments · Fixed by #60016
Assignees
Labels
[Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.

Comments

@SaxonF
Copy link
Contributor

SaxonF commented Mar 20, 2024

What problem does this address?

When editing a page in the site editor and clicking outside an editable block (title, featured image, post content) we currently show a toast notification to edit the template. The original intention of this was to provide quicker, more contextual pathways towards editing a template a page uses. Feedback, and further testing, suggests this might not be necessary and removing may actually help force people to add content to pages instead.

What is your proposed solution?

I'd like to propose two changes:

  • Remove the toast notification
  • Adjust behaviour so when you click part of a template that is not editable, we select the closest editable block. The definition of closest would be 1. The first child within the clicked block that is editable 2. If no child exists, move to sibling blocks and find editable child 3. if no sibling, move up the tree until a sibling exists.

With #60010 we are making headers/footers editable which gives you quicker access to a global block that may need to be adjusted as pages are added to your site. Editing the rest of a template is less common.

As a step after this we can make template edit/swapping a more prominent part of the page inspector.

@SaxonF SaxonF added the [Type] Enhancement A suggestion for improvement. label Mar 20, 2024
@noisysocks
Copy link
Member

Would we still need the flash of dotted outlines around editable blocks?

@jordesign jordesign added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Mar 20, 2024
@SaxonF
Copy link
Contributor Author

SaxonF commented Mar 20, 2024

@noisysocks yep that's still useful , we're just taking the next step and selecting something

@noisysocks noisysocks added the [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. label Mar 20, 2024
@noisysocks noisysocks self-assigned this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants