Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include automated test for ensuring all fields include labels #6098

Closed
danielbachhuber opened this issue Apr 10, 2018 · 4 comments
Closed

Include automated test for ensuring all fields include labels #6098

danielbachhuber opened this issue Apr 10, 2018 · 4 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Comments

@danielbachhuber
Copy link
Member

For accessibility purposes, all Gutenberg fields should include labels. Because it's easy for humans to forget this, it would be ideal to include some automated test to force this.

cc @afercia

From #6033 (comment)
@danielbachhuber danielbachhuber added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Apr 10, 2018
@afercia
Copy link
Contributor

afercia commented Apr 10, 2018

Thanks @danielbachhuber this is something I'd definitely recommend to consider. See also empty and unlabelled buttons #5823 (comment)

Since it happened several times that completely unlabeled elements were introduced in the UI, would it be feasible to use some specific tests? Specifically for buttons, is there any easy way to add tests to check if the buttons have some text or some non-empty aria-label to not allow empty buttons?

@danielbachhuber danielbachhuber mentioned this issue Apr 10, 2018
Open
This was referenced Apr 16, 2018
Closed
Closed
@danielbachhuber
Copy link
Member Author

Filing against the Ideas project for now, as this isn't critical for WordPress 5.0

@afercia
Copy link
Contributor

afercia commented May 28, 2018

@danielbachhuber sorry probably I'm missing something but I can't find it under the Ideas project.

@afercia afercia mentioned this issue May 28, 2018
Merged
@tofumatt tofumatt mentioned this issue May 29, 2018
Closed
@danielbachhuber
Copy link
Member Author

@afercia It's "Awaiting Triage":

image

image

@afercia afercia mentioned this issue Jul 21, 2018
Closed
@afercia afercia mentioned this issue Sep 1, 2018
Closed
@afercia afercia mentioned this issue Aug 11, 2020
Closed
@afercia afercia mentioned this issue Aug 25, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielbachhuber @afercia