Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block: 'Insert link' is broken #6158

Closed
noisysocks opened this issue Apr 13, 2018 · 2 comments
Closed

Image block: 'Insert link' is broken #6158

noisysocks opened this issue Apr 13, 2018 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Milestone

Comments

@noisysocks
Copy link
Member

Issue Overview

The Insert link functionality in an image block's toolbar is broken.

Steps to Reproduce (for bugs)

  1. Insert an image block
  2. Click the Insert link button in the toolbar
  3. Type in the title of a published post

Expected Behavior

A list of posts appear which can be selected with the arrow keys.

Current Behavior

The toolbar disappears.

Possible Solution

Probably need to put an event.stopPropagation() into the UrlInput onKeyPress event.

Screenshots / Video

screen shot 2018-04-12 at 11 01 05

Related Issues and/or PRs

It looks like #5513 introduced this regression.

@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Apr 13, 2018
@noisysocks noisysocks added this to the Merge Proposal: Editor milestone Apr 13, 2018
@JeroenSormani
Copy link

Can confirm its broken on version 2.6.0

Trying to type anything into the field doesn't work:
screen recording 2018-04-15 at 12 42 pm

Navigating left/right or trying to remove something with backspace doesn't work as expected either:
screen recording 2018-04-15 at 12 43 pm

Expected behaviour here would be to be able to move the cursor left/right to be able to edit a link.
Current behaviour it navigates the link options, even on input field focus

@youknowriad
Copy link
Contributor

This has been fixed in 2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants