Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey color behind caption in Image Gallery #7260

Closed
paaljoachim opened this issue Jun 11, 2018 · 3 comments
Closed

Grey color behind caption in Image Gallery #7260

paaljoachim opened this issue Jun 11, 2018 · 3 comments

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Jun 11, 2018

I am seeing a grey background behind the captions.

caption-adds-grey

Desktop (please complete the following information):

  • OS: OSX 10.13.4
  • Browser: Chrome
  • Version: Newest version 3.0.1
@anevins12
Copy link
Contributor

@paaljoachim, What makes you think this is a bug? It looks like this is decision choice to ensure text always has enough colour contrast against background colour.

@paaljoachim
Copy link
Contributor Author

@anevins12
Hey Andrew.
The background grey color is something I did not decide to add. It feels really out of place. It made me think it was a bug. If it is forced on the user then it should also be up to the user if they want to add a color and if so which color.

@jasmussen
Copy link
Contributor

We discussed this in Slack: https://wordpress.slack.com/archives/C02QB2JS7/p1528897452000879

For the time being, this is intentional, and something themes can override both in the frontend and using an editor style in the editor itself. Presumably plugins could provide options here as well. For now I'm closing this, and then we can revisit if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants