Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InnerBlocks Layout Documentation is out of date #7868

Closed
belcherj opened this issue Jul 10, 2018 · 2 comments
Closed

InnerBlocks Layout Documentation is out of date #7868

belcherj opened this issue Jul 10, 2018 · 2 comments
Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@belcherj
Copy link
Contributor

belcherj commented Jul 10, 2018 •
edited

Describe the bug
https://github.com/WordPress/gutenberg/tree/master/editor/components/inner-blocks#layouts is out of date given the new nesting in the Columns block

<!-- wp:columns -->
<div class="wp-block-columns">
	<!-- wp:paragraph {"layout":"column-1"} -->
	<p>First Paragraph</p>
	<!-- /wp:paragraph -->

	<!-- wp:paragraph {"layout":"column-1"} -->
	<p>Second Paragraph</p>
	<!-- /wp:paragraph -->

	<!-- wp:paragraph {"layout":"column-2"} -->
	<p>Third Paragraph</p>
	<!-- /wp:paragraph -->
</div>
<!-- /wp:columns -->

The columns should be nested. I think this section should be reworked given the changes. Some of what is being described no longer makes sense.
@chrisvanpatten
Copy link
Member

This will be fixed with #7841.

@designsimply designsimply added [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed labels Jul 11, 2018
@designsimply
Copy link
Member

Closing in favor of #7841. Thank you for posting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@designsimply @chrisvanpatten @belcherj