Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashed block z-index problem with add new block button #8868

Closed
johngodley opened this issue Aug 11, 2018 · 1 comment
Closed

Crashed block z-index problem with add new block button #8868

johngodley opened this issue Aug 11, 2018 · 1 comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@johngodley
Copy link
Contributor

Describe the bug

If a block crashes it shows a crashed block warning. There is some z-index issue with this and the inline 'add new block' button:

another_post___ wordpress_latest _wordpress

To Reproduce
Steps to reproduce the behavior:

  1. In dev console enter wp.blocks.registerBlockType( 'myplugin/mr-crashy', { title: 'Mr. Crashy', category: 'common', icon: 'warning', edit() { throw new Error(); }, save() { return ''; } } );
  2. Add Mr Crashy block
  3. Note that the inline block add buttons appear under the crash warning

Expected behavior
The inline block buttons should appear over the crash warning

There's also a slight overlap in the crash warning that can be fixed by changing block-list/style.scss with:

.editor-block-list__layout .editor-block-list__block {
	&.has-warning {
		min-height: ( $block-padding + $block-spacing ) * 2;
	}
@johngodley johngodley added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Aug 11, 2018
@johngodley
Copy link
Contributor Author

Closing as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant