Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some parts of the layout break with longer translations #9537

Closed
afercia opened this issue Sep 1, 2018 · 2 comments
Closed

Some parts of the layout break with longer translations #9537

afercia opened this issue Sep 1, 2018 · 2 comments
Assignees
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Sep 1, 2018

The UI should take into account longer translations and, in some cases, also custom post types that could have long names.

At this point of the project, the UI should be thoroughly tested in as many different languages as possible. I've quickly switched through a few languages and noticed some layout issues. Some of them are minor, other ones are a bit more serious.

Especially flexbox seems not appropriate in some cases: while it's handy to have correct alignments, it doesn't allow elements to wrap as necessary, unless flex-wrap is used properly.

A few examples:

The View Post and Copy Link buttons in the publishing flow: when a post has a long name, the second button is partially cut-off:

screen shot 2018-09-01 at 15 26 42

Same happens in some languages with existing custom post types that have long names: this is Jetpack Testimonials in Italian:

screen shot 2018-09-01 at 15 28 58

In other parts of the UI I've noticed minor issues: the UI can still be used but it's not so nice to see:

Image size in German:

screen shot 2018-09-01 at 15 42 59

Text size in German:

screen shot 2018-09-01 at 15 43 23

I wonder what might happen in the mobile view, and when plugins will start adding their buttons on the toolbar and in other parts of the UI. Generally, I'd tend to think that the usage of flexbox in these problematic cases should be reviewed to gracefully allow elements to wrap when necessary.

@afercia afercia added [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts Needs Design Feedback Needs general design feedback. labels Sep 1, 2018
@mtias
Copy link
Member

mtias commented Oct 8, 2018

@sarahmonster when you have some time, could you look at the publish panel one? The fonts is no longer relevant after #9802.

@sarahmonster
Copy link
Member

This should be solved longer-term by the changes planned in #9398, but since that's a wee bit stalled I've put together a quick PR in #10514 to ensure these buttons can't ever get pushed off-screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants