Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass feature image id to media upload component #10264

Conversation

jorgefilipecosta
Copy link
Member

Description

Fixes: #9982

The feature image id was not being passed to MediaUpload component in the feature image component, so clicking on the image would open the media library but wouldn't select the image correctly.

How has this been tested?

Create a new post. Add a featured image. Save the post reload the editor and click the Feature Image. Verify it was correctly selected in the media library.

In collaboration with @pento.

@jorgefilipecosta jorgefilipecosta added this to the 4.0 milestone Sep 30, 2018
@jorgefilipecosta jorgefilipecosta requested a review from a team September 30, 2018 20:17
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jorgefilipecosta jorgefilipecosta merged commit 71fc9bb into master Oct 1, 2018
@jorgefilipecosta jorgefilipecosta deleted the fix/9982-feature-image-id-not-passed-media-upload-component branch October 1, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants