Replace TinyMCE decode entities

[ellatrix]

Description

Replace TinyMCE function to decode entities with existing Gutenberg package.

How has this been tested?

Copy paste for example http://example.com/path/to/page?name=gutenberg&color=black on top of a selection. A link should be created and the "&" character should be decoded.

I was looking at adding an e2e test but didn't find anything useful right away to do pasting.

Screenshots

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[tofumatt]

Makes sense to me! I think I can add a test for copy/pasting if there's no huge rush on merging this (like an hour or so!)

[ellatrix]

Sounds good! Thanks!

…

On Tue, 2 Oct 2018 at 10:56, Matthew Riley MacPherson < ***@***.***> wrote: ***@***.**** approved this pull request. Makes sense to me! I think I can add a test for copy/pasting if there's no huge rush on merging this (like an hour or so!) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10283 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEfg668z1CDDgAfRmHXZ-2Yll0-WQQZ4ks5ug36KgaJpZM4XDE_Y> .

[tofumatt]

Clipboard tests in Puppeteer are super weird and not straightforward.

I tried:

it( 'should create a link from a pasted URL ', async () => {
		const url = 'http://example.com/path/to/page?name=gutenberg&color=black';
		// Create some text, including the URL we want to copy/paste.
		await clickBlockAppender();
		await page.keyboard.type( `First paragraph ${ url }` );

		// Select the URL in this paragraph.
		for ( let i = 0; i < url.length; i++ ) {
			await pressWithModifier( 'Shift', 'ArrowLeft' );
		}

		// Copy the URL.
		await pressWithModifier( META_KEY, 'C' );

		// Move the cursor back to the end and create a new paragraph.
		for ( let i = 0; i < url.length; i++ ) {
			await pressWithModifier( 'Shift', 'ArrowRight' );
		}
		await page.keyboard.press( 'Enter' );
		await page.keyboard.type( 'Second paragraph where we can replace the last word.' );

		// Select the last word and paste the URL.
		await page.keyboard.press( 'ArrowLeft' );
		for ( let i = 1; i <= 4; i++ ) {
			await pressWithModifier( 'Shift', 'ArrowLeft' );
		}
		await pressWithModifier( META_KEY, 'P' );

		expect( await getEditedPostContent() ).toMatchSnapshot();
	} );

but it never copy/pasted. I say just merge this and I will work on the tests for a later PR.