Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Font size default classes. #10719

Merged
merged 1 commit into from Oct 18, 2018
Merged

Fix: Font size default classes. #10719

merged 1 commit into from Oct 18, 2018

Conversation

jorgefilipecosta
Copy link
Member

Description

Regressed in: #9802

In PR #9802 we added two new slugs, medium, and huge, but the corresponding classes were not added has-medium-font-size and has-huge-font-size.
This PR adds the missing classes.

How has this been tested?

I created a paragraph for each named font size and verified a corresponding class exists on the front end.

@jorgefilipecosta jorgefilipecosta added the [Type] Bug An existing feature does not function as intended label Oct 18, 2018
@jorgefilipecosta jorgefilipecosta added this to the 4.1 - UI freeze milestone Oct 18, 2018
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gziolo
Copy link
Member

gziolo commented Oct 18, 2018

Confirmed, works as advertised 👍

@gziolo gziolo merged commit 73ce8fd into master Oct 18, 2018
@gziolo gziolo deleted the fix/font-size-classes branch October 18, 2018 09:12
antpb pushed a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants