Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space above code editor toolbar #10898

Merged

Conversation

chrisvanpatten
Copy link
Member

The code editor toolbar previously had no space above it, so the hover state of the "Exit Code Editor" button bumped up against the top toolbar. This PR resolves that!

Before
edit_page_ tomodomo _wordpress

After
edit_page_ tomodomo _wordpress

@chrisvanpatten chrisvanpatten added the [Type] Enhancement A suggestion for improvement. label Oct 22, 2018
@jasmussen
Copy link
Contributor

jasmussen commented Oct 22, 2018

Boy Github is being annoying today. This PR 404s half the time.

This looks good — how does the button text align with the text on the left?

@chrisvanpatten
Copy link
Member Author

@jasmussen The whole toolbar is moved here, so the text on the left moves down too. (So the baseline is the same and it looks nice!)

@jasmussen
Copy link
Contributor

In that case, I'm a fan, and normally I'd just say SHIP IT!

But we're beyond the UI freeze date, I believe. If this counts as a bugfix, then it's okay to ship, but if it's a UI change, less so. What's our argument here? I guess it was a bit close to the edge wasn't it?

@chrisvanpatten
Copy link
Member Author

@jasmussen I saw some PRs with bigger UI changes get re-milestoned as 4.2 because they were "enhancements" so I feel like this is pretty fair to allow in as a Bug Fix. That said, it's pretty small so it's not really the end of the world if it needs to be revisited later.

@jasmussen jasmussen added this to the 4.2 milestone Oct 22, 2018
@chrisvanpatten
Copy link
Member Author

@jasmussen Travis is passing finally, so this is ready for review :)

Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2018-10-24 at 09 11 38

Looks good. Ship it!

@chrisvanpatten chrisvanpatten merged commit b2c999e into WordPress:master Oct 24, 2018
@chrisvanpatten chrisvanpatten deleted the fix/code-editor-toolbar-padding branch October 24, 2018 10:03
antpb pushed a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants