New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save meta on preview #11409
Merged
Merged
Save meta on preview #11409
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0c46e21
Set the preview url once metabox and autosaves are complete.
b17b85f
when previewing, requestMetaBoxUpdates
8e54535
Merge branch 'master' of github.com:WordPress/gutenberg
acde4a5
Merge branch 'master' of github.com:WordPress/gutenberg
20691f3
Merge branch 'master' of github.com:WordPress/gutenberg
89660bc
Merge branch 'master' of github.com:WordPress/gutenberg
ecf175d
Merge branch 'master' into fix/save-meta-on-preview
ee275cc
move preview autosave logic into edit-post effects
a842446
update docs & save logic
b757300
Merge remote-tracking branch 'origin/master' into fix/save-meta-on-pr…
youknowriad 74035ca
Fix save metaboxes condition
youknowriad 8ab9863
Refresh preview after metabox save
youknowriad f2f1514
Fix consecutive previews
youknowriad da53820
Fix unit tests
youknowriad de2a5f1
Fix autosaving status
youknowriad 7e707c7
Merge remote-tracking branch 'origin/master' into fix/save-meta-on-pr…
youknowriad 99f5bca
Always return a boolean value from isAutosave selector.
youknowriad File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's slightly weird that preview would have this side-effect but it wouldn't be evident from selector name. Though I guess it matches the expectation of the action itself.